Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference vs ora - double printing on exit #32

Closed
JamesHenry opened this issue Nov 5, 2024 · 3 comments
Closed

Difference vs ora - double printing on exit #32

JamesHenry opened this issue Nov 5, 2024 · 3 comments

Comments

@JamesHenry
Copy link

Thanks for the great work to help make the ecosystem more efficient!

I would like to replace our usage of ora with nanospinner in https://github.com/nrwl/nx - our overall tracking issue is here: es-tooling/ecosystem-cleanup#117

I went through our usage and fortunately we don't require the multiple spinners support. Things are nearly ready to go but I found one blocking bug, here is a repro:

https://stackblitz.com/edit/stackblitz-starters-dmnx9n?file=package.json&view=editor

  • Run node ora.js
  • Run node nanospinner.js

You will see that ora does not print again after the error message is printed as expected, but nanospinner does.

image

image

@usmanyunusov
Copy link
Owner

@JamesHenry I'll take a look soon

@usmanyunusov
Copy link
Owner

usmanyunusov commented Dec 9, 2024

@JamesHenry fix release 1.2.2

@JamesHenry
Copy link
Author

Ah cool thank you @usmanyunusov, I also wanted to make you aware of the discussion happening here: tinylibs/picospinner#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants