Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update faq entry about stylus inline search #308

Conversation

pabuisson
Copy link
Contributor

Why?

I published a style on userstyles.world a few days ago. But it was still not appearing in stylus inline search. I found the FAQ but it was only mentioning that the category had to be present (which was the case) and mention the subdomain (no subdomain in my case).

After waiting a bit more, trying to understand what was wrong, I piggybacked on a stylus issue (see openstyles/stylus#1777) and understood that for .com and .org domains, the TLD had to be omitted, an information I could find nowhere.

What?

  • doc: complete the faq.md page and explain this org/com TLD thing.

Of course feel free to suggest better wording if you have anything, or tell me if you want to incorporate more details in this section.

@pabuisson pabuisson marked this pull request as ready for review May 25, 2024 15:16
@pabuisson pabuisson marked this pull request as draft May 27, 2024 17:42
@pabuisson pabuisson marked this pull request as ready for review May 27, 2024 17:42
@astyled
Copy link
Contributor

astyled commented May 29, 2024

The Stylus logic is confusing but your correction is indeed correct. Thank you.

While I can approve and merge, I do not deploy updates on USw, @vednoc does, so it will make sense to wait for him to review instead.

@pabuisson
Copy link
Contributor Author

No problem, there's no rush for me, as I finally understood how it worked. But making at least the FAQ a bit more detailed about this should help other users too. Thanks for the feedback and we'll wait for @vednoc then!

@vednoc vednoc changed the base branch from main to dev July 1, 2024 20:23
Copy link
Member

@vednoc vednoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We used to have code that would strip .com and .org during generation of the index used by Stylus. If I remember correctly, it was removed in one of many performance optimizations, and it was never added to pages that handle adding/importing/editing userstyles. We'll take care of that separately. Maybe @astyled will open an issue for it. 😄

@vednoc vednoc merged commit cddd18c into userstyles-world:dev Jul 1, 2024
vednoc added a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants