Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cache system #838

Open
1 of 4 tasks
lcharette opened this issue Jan 5, 2018 · 2 comments
Open
1 of 4 tasks

Refactor cache system #838

lcharette opened this issue Jan 5, 2018 · 2 comments
Assignees
Labels
architecture Related to the framework architecture standards and best practices Coding guidelines
Milestone

Comments

@lcharette
Copy link
Member

lcharette commented Jan 5, 2018

The current UF cache package is overly complicated for nothing and inconsistent. For example, we create a new RedisStore, but have to call getInstance() to actually get a RedisStore.

Instead of creating singleton and fake app to create the RedisManager, it should probably be easier to directly implement our own CacheManager instead so we don't have to deal with Laravel app instance. Instead of defining RedisManager in $app it could probably be done in CacheManager directly.


TODO

  • Refactor cache package with our own CacheManager
  • Allows for multiple cache store to be used from the cache service
  • Add a cache Facade
  • Add array store to disable caching
@lcharette lcharette added architecture Related to the framework architecture standards and best practices Coding guidelines labels Jan 5, 2018
@lcharette lcharette added this to the 4.3.0 milestone Jan 5, 2018
@lcharette lcharette self-assigned this Jan 5, 2018
@lcharette
Copy link
Member Author

Also while the cache service provides one cache store at a time, it could be useful allow for multiple cache store to be used.

Incidentally, the clear-cache Bakery command could also accept more options.

@lcharette
Copy link
Member Author

...and it would require a way to globally disable cache (aka enable the arraystore)

lcharette added a commit that referenced this issue Nov 13, 2018
@lcharette lcharette modified the milestones: 4.4.0, 4.5.0 Jan 11, 2020
@lcharette lcharette modified the milestones: 4.x.x, 5.1.0 Nov 25, 2023
@lcharette lcharette moved this to Todo 5.1.0 in UserFrosting Task Planner Nov 26, 2023
@lcharette lcharette moved this from Todo 5.1.0 to Todo 5.2.0 in UserFrosting Task Planner Feb 10, 2024
@lcharette lcharette modified the milestones: 5.1.0, 5.2.0 Feb 17, 2024
@lcharette lcharette moved this from Todo 5.2.0 to Not Started in UserFrosting Task Planner Apr 13, 2024
@lcharette lcharette modified the milestones: 5.2.0, 5.3.0 Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Related to the framework architecture standards and best practices Coding guidelines
Projects
Status: Not Started
Development

No branches or pull requests

1 participant