Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to various go modules #3783

Open
shreddedbacon opened this issue Jul 28, 2024 · 1 comment
Open

Updates to various go modules #3783

shreddedbacon opened this issue Jul 28, 2024 · 1 comment

Comments

@shreddedbacon
Copy link
Member

#3782 discovered some out of date packages that require additional work to update

  • github.com/Khan/genqlient v0.3.0 module in services/workflows could not be updated due to a change in the MakeRequest structure in v0.5.0 that will require attention

  • github.com/cheshir/go-mq/v2 module in services/workflows fails vet with a "passes lock by value" error - unsure about this

  • k8s.io/* modules in task-activestandby fail tests (around IngressList structure) when updated to 1.30.x - this will require attention (I think to modify the expected result JSON)
@shreddedbacon
Copy link
Member Author

Additionally, logs2notifications can be updated to use machinery

@shreddedbacon shreddedbacon mentioned this issue Jul 28, 2024
Merged
@shreddedbacon shreddedbacon mentioned this issue Aug 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shreddedbacon