Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check production_routes, warn if environment is not an environment #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Check production_routes, warn if environment is not an environment #9

wants to merge 2 commits into from

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Nov 1, 2021 •
edited
Loading

This is just an idea on being able to check if configuration of an environment is actually able to unmarshal into an environment.

@tobybellwood Since .lagoon.yml has so many things that look like they could break, but actually pass in a build, it will be hard to capture every little edge case until we properly implement an actual spec for it. Which we should look at doing sooner rather than later.

closes #7, closes #8

@shreddedbacon shreddedbacon force-pushed the production-routes-warning branch 2 times, most recently from a1a9c19 to 84e77cc Compare November 1, 2021 06:07
@shreddedbacon shreddedbacon force-pushed the production-routes-warning branch from 84e77cc to a4154f6 Compare November 1, 2021 06:09
@shreddedbacon shreddedbacon force-pushed the production-routes-warning branch from 3c7ff12 to 0ad6173 Compare November 1, 2021 06:48
tobybellwood
tobybellwood approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This meets the objectives:

  • better handling of non-conformant (but still Lagoon-valid) YAML
  • handling of annotations on Active/Standby routes
  • More targetted error messages
  • Only failing on actual policy violations

smlx
smlx reviewed Nov 1, 2021
View reviewed changes
Copy link
Member

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack, this has a couple of issues with validating routes.

The "hard-fail" behaviour that this PR fixes can be split out if required, but I think we need a bit more discussion on what the best thing to do here is.

@smlx smlx mentioned this pull request Nov 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlx smlx smlx left review comments

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shreddedbacon @smlx @tobybellwood