Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lagoon-logging] cdn-logs-collector metrics missing #706

Open
xantrix opened this issue Dec 6, 2024 · 1 comment
Open

[lagoon-logging] cdn-logs-collector metrics missing #706

xantrix opened this issue Dec 6, 2024 · 1 comment

Comments

@xantrix
Copy link
Contributor

xantrix commented Dec 6, 2024

We found with @anothertobi that the Servicemonitor tries to scrape a non-existent port on the service
https://github.com/uselagoon/lagoon-charts/blob/main/charts/lagoon-logging/templates/cdn-logs-collector.servicemonitor.yaml#L13

The metrics port is available on the pod
https://github.com/uselagoon/lagoon-charts/blob/main/charts/lagoon-logging/templates/cdn-logs-collector.statefulset.yaml#L49

Possible solution:

@smlx
Copy link
Member

smlx commented Dec 9, 2024

Nice find! IMO the additional service makes the most sense since it matches the approach we already have with other logging charts. e.g. https://github.com/uselagoon/lagoon-charts/blob/main/charts/lagoon-logs-concentrator/templates/metrics-service.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants