Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jQuery #392

Open
4 of 5 tasks
Wolfr opened this issue Jul 8, 2021 · 1 comment
Open
4 of 5 tasks

Deprecate jQuery #392

Wolfr opened this issue Jul 8, 2021 · 1 comment

Comments

@Wolfr
Copy link
Contributor

Wolfr commented Jul 8, 2021

All JS in Bedrock's core should be written as vanilla JS, not using jQuery. This was mentioned before but this is the “official” issue to track progress.

import $ from 'jquery';

import './prototype-nav';
import './styleguide-code-samples';
import './styleguide-typography';
import './styleguide-search';
import rememberScroll from './styleguide-remember-scroll';

window.$ = $;

rememberScroll('#__prototype-nav');
rememberScroll('.br-styleguide-content');
rememberScroll('.br-styleguide-navigation-holder');
  • './prototype-nav'; needs to be looked at, this is the hardest one
  • Code samples is well under way (in prism branch)
  • './styleguide-typography'; is done
  • './styleguide-search'; needs to be looked at, should be fairly simple Rewrite styleguide-search to vanilla JS #405
  • rememberScroll
@Wolfr
Copy link
Contributor Author

Wolfr commented Nov 29, 2021

Prototype nav is the one that's left, there is a PR but it doesn't work yet.
#370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant