Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on exclude_patterns #60

Open
shyndman opened this issue Oct 5, 2021 · 4 comments
Open

Clarification on exclude_patterns #60

shyndman opened this issue Oct 5, 2021 · 4 comments

Comments

@shyndman
Copy link

shyndman commented Oct 5, 2021

Hi there,

I was playing around with your library, and had to dig into your code to see how exclude patterns work. I think I understand correctly that they're substrings (not glob/regex) that can appear in a URL to exclude it from consideration.

Might I suggest that their format and use is clarified in the docs?

@vsoch
Copy link
Collaborator

vsoch commented Oct 5, 2021

Sure! That would be very helpful! If you’d like to submit a PR I would also be happy to give you credit for a Hacktoberfest contribution.

@shyndman
Copy link
Author

shyndman commented Oct 5, 2021

Sure, happy to. Give me a few.

@shyndman
Copy link
Author

shyndman commented Oct 5, 2021

OK, I'm in it. I'm finding a few inconsistencies. Mind if I do a bit of surgery, now that I'm in here?

@vsoch
Copy link
Collaborator

vsoch commented Oct 6, 2021

go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants