Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: provider based packaging #10

Open
YvanDaSilva opened this issue Nov 16, 2024 · 4 comments · May be fixed by #11
Open

feature: provider based packaging #10

YvanDaSilva opened this issue Nov 16, 2024 · 4 comments · May be fixed by #11

Comments

@YvanDaSilva
Copy link

Hello,

Looking at this repo while trying CLI V3, I noticed that all altsrc are on the same package.
Since you moved these sources to a separate repository, I assume you would want to add more providers.

Because of this I would expect to not have to import all supported config providers if I don't need them.
I.E. vault, aws secrets, one password, etc.

Would you be interested in this change?

Keep up the great work.
@dearchap
Copy link
Contributor

@YvanDaSilva that makes sense. In this case json/yaml etc share a lot in common so we had used a common infrastructure for that. if you are doing any providers totally different from them then yeah putting it in a separate dir/package is better

@YvanDaSilva
Copy link
Author

@dearchap Thanks for your answer.
We could stil put them in a package then that would provide json and yaml.
Alsp I wonder then if TOML could be a candidate to move to a different package.

@abitrolly
Copy link
Contributor

I thought that Go allows to maintain multiple packages in a single repo.

@YvanDaSilva
Copy link
Author

I thought that Go allows to maintain multiple packages in a single repo.

It absolutely does.
Having a separate repo is a choice.

You can take a look at koanf repo how you can manage multiple go packages with a single repo.

@dearchap dearchap linked a pull request Nov 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat:(issue_10) Move providers into separate paths dearchap/cli-altsrc
3 participants
@dearchap @YvanDaSilva @abitrolly