Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stun: fix stun #694

Merged
merged 1 commit into from
Aug 2, 2024
Merged

stun: fix stun #694

merged 1 commit into from
Aug 2, 2024

Conversation

pkova
Copy link
Collaborator

@pkova pkova commented Aug 2, 2024

Informal pinging has been broken since #623, luckily this was unreleased, but existed edge.

@pkova pkova requested a review from a team as a code owner August 2, 2024 15:52
Copy link
Member

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, my apologies

@pkova pkova merged commit 148219d into develop Aug 2, 2024
5 checks passed
@pkova pkova deleted the pkova/stun-fix branch August 2, 2024 16:08
@pkova
Copy link
Collaborator Author

pkova commented Aug 2, 2024

For posterity, even testers on edge would not have experienced lessened connectivity because of this because if informal pinging fails we fall back to formal pinging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants