Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle cases where urbit roll didn't complete successfully #530

Closed
matthew-levan opened this issue Sep 29, 2023 · 6 comments · Fixed by #531
Closed

Gracefully handle cases where urbit roll didn't complete successfully #530

matthew-levan opened this issue Sep 29, 2023 · 6 comments · Fixed by #531

Comments

@matthew-levan
Copy link
Contributor

This happened on @jalehman's ~siddef ship.
@joemfb
Copy link
Member

joemfb commented Oct 4, 2023

@matthew-levan do you have any more details about how roll had failed, or what the subsequent error was?

@joemfb joemfb mentioned this issue Oct 4, 2023
Merged
@matthew-levan
Copy link
Contributor Author

@matthew-levan do you have any more details about how roll had failed, or what the subsequent error was?

@mopfel-winrux may, as it was running on a NP.

@mopfel-winrux
Copy link
Contributor

It was due to the docker version switching from 3.0 back to 2.12

@joemfb
Copy link
Member

joemfb commented Oct 4, 2023

Ok, great. That's fixed in #531.

@joemfb
Copy link
Member

joemfb commented Oct 4, 2023

Ie, re-upgrade after downgrade will resolve the issue.

@matthew-levan
Copy link
Contributor Author

Ok so we can close this after #531 gets reviewed and merged then.

pkova added a commit that referenced this issue Oct 11, 2023
@pkova
epoc: cleanup (#531)
9bdc1af 
This PR cleans up the new epoch system from #459, fixing some small
bugs, plugging leaks, and simplifying the interface to it.

It still needs a final round of crash recovery testing (killing the
process at every stage of the intialization/migration, confirming that
subsequent restarts proceed as they should).

Resolves #530.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

epoc: cleanup urbit/vere
3 participants
@mopfel-winrux @joemfb @matthew-levan