Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale #287

Open
disaerna opened this issue Nov 30, 2021 · 5 comments · Fixed by #311
Open

Locale #287

disaerna opened this issue Nov 30, 2021 · 5 comments · Fixed by #311
Labels
question

Comments

@disaerna
Copy link

Question

Hi there, I added a new locale translations for Icelandic on uploadcare/uploadcare-widget - is it possible to merge it with this library?
@optlsnd
Copy link

optlsnd commented Nov 30, 2021

Hi @disaerna, you can simply run npm update uploadcare-widget in your project. As a result, the uploadcare-widget package will be updated to the latest version, and you'll be able to use the Icelandic locale.

@disaerna
Copy link
Author

disaerna commented Feb 4, 2022

Thanks for the answer 👍 I updated my package and all packages are up to date.
But after updateing my translations are still not added to the Locale type in */types/index.d.ts.
Am I missing something?

@disaerna
Copy link
Author

disaerna commented Mar 4, 2022

? 🤔

@nd0ut nd0ut mentioned this issue Mar 4, 2022
Merged
@nd0ut nd0ut closed this as completed in #311 Mar 4, 2022
@nd0ut
Copy link
Member

nd0ut commented Mar 4, 2022 •
edited
Loading

@disaerna I updated widget version and added Icelandic locale to the typings. Check v1.3.10 please.

@nd0ut nd0ut reopened this Mar 4, 2022
@disaerna
Copy link
Author

disaerna commented Mar 4, 2022 •
edited
Loading

Great 💯 Thank you - Will test on monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump widget version uploadcare/react-widget
3 participants
@nd0ut @optlsnd @disaerna