Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backport): upgrade, cleanup before backport from caas #43

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Oct 26, 2023

Description of your changes

  • upgrade build module
  • bump uptest
  • bump up-cli
  • remove outdated pictures without reference to documents
  • switch package to apis
  • update makefile
  • stop running publish action in forks without ci variable

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

@haarchri haarchri requested a review from ytsarev October 26, 2023 09:49
@haarchri haarchri mentioned this pull request Oct 26, 2023
3 tasks
@ytsarev
Copy link
Member

ytsarev commented Oct 26, 2023

/test-examples

@ytsarev
Copy link
Member

ytsarev commented Oct 27, 2023

@haarchri uptest failed here

@haarchri
Copy link
Member Author

local run:

--- PASS: kuttl (1526.62s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (1525.39s)
PASS
09:14:04 [ OK ] running automated tests

Signed-off-by: Christopher Haar <[email protected]>
@haarchri
Copy link
Member Author

/test-examples

@haarchri
Copy link
Member Author

okay the issue here is:

lastTransitionTime: "2023-10-27T07:24:38Z"
message: 'observe failed: cannot run refresh: refresh failed: building account:
  could not acquire access token to parse claims: clientCredentialsToken: received
  HTTP status 401 with response: ***"error":"invalid_client","error_description":"AADSTS7000222:
  The provided client secret keys for app ''86d55993-6f8b-4012-8201-5a9dceb8b327''
  are expired. Visit the Azure portal to create new keys for your app: https://aka.ms/NewClientSecret,
  or consider using certificate credentials for added security:

@haarchri
Copy link
Member Author

/test-examples

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the credentials issue, LGTM

@haarchri haarchri merged commit 9b6d54c into main Oct 27, 2023
2 checks passed
@haarchri haarchri deleted the feature/move-package-upgrades branch January 5, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants