Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A subcommand to render manifests and include dependencies #57

Open
turkenh opened this issue Dec 21, 2022 · 0 comments
Open

A subcommand to render manifests and include dependencies #57

turkenh opened this issue Dec 21, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@turkenh
Copy link
Member

turkenh commented Dec 21, 2022

What problem are you facing?

We have the following two problems which could be resolved together with an intermediate render step:

  • When a managed resource depends on other resources, we put them as YAMLs next to the resource we want to test duplicating manifests. For example, in the provider-aws, APIKey depends on GraphQLAPI, and we put it into examples/appsync/apikey.yaml whereas we have examples/appsync/graphqlapi.yaml with the same manifest.
  • We have examples published to Upbound Marketplace with uninjected data source values (e.g. ${data.aws_region} , ${data.aws_account_id}) confusing users.

How could Upbound help solve your problem?

Implement a subcommand, e.g., uptest render, which takes care of including manifest YAML (e.g. with an #include statement) from other files and injecting data source values.

  • To solve the first problem, we can execute this before running uptest e2e to get complete/ready-to-test example YAMLs.
  • To solve the second problem, we can run this with some dummy datasource values (e.g. aws_account_id=1234567890) before publishing examples to the marketplace.
@turkenh turkenh added enhancement New feature or request needs-epic-link labels Dec 21, 2022
@jeanduplessis jeanduplessis added this to the 1.0 milestone Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants