Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(status): add status for vpcId and private/publicSubnetId #29

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jan 27, 2024

Description of your changes

  • add new status for vpcId
  • add new status for privateSubnetId and publicSubnetId
  • re-order the patches

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

new status fields available:

--- PASS: kuttl (344.81s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (344.35s)
PASS
10:04:16 [ OK ] running automated tests
  status:
    conditions:
    - lastTransitionTime: "2024-01-26T11:26:04Z"
      reason: ReconcileSuccess
      status: "True"
      type: Synced
    - lastTransitionTime: "2024-01-26T09:31:09Z"
      reason: Available
      status: "True"
      type: Ready
    connectionDetails:
      lastPublishedTime: "2024-01-26T09:28:06Z"
    privateSubnetIds:
    - subnet-0415d100bdc1af806
    - subnet-0fe4596df8cdf3075
    publicSubnetIds:
    - subnet-05e0114de10069cc7
    - subnet-0ba1fc98978556e25
    securityGroupIds:
    - sg-0aa44bd34033dc678
    subnetIds:
    - subnet-05e0114de10069cc7
    - subnet-0ba1fc98978556e25
    - subnet-0415d100bdc1af806
    - subnet-0fe4596df8cdf3075
    vpcId: vpc-0a0265e20e09c62ec

@haarchri
Copy link
Member Author

/test-examples

@haarchri haarchri requested a review from ytsarev January 27, 2024 10:52
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please expand How has this code been tested part to demonstrate tested values propagation?

@haarchri
Copy link
Member Author

done

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haarchri haarchri merged commit a49bbf5 into main Jan 28, 2024
2 checks passed
@haarchri haarchri deleted the feature/status branch January 29, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants