Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add gif functionality to images view #15

Closed
NoozAbooz opened this issue Nov 22, 2023 · 4 comments
Closed

Feature Request: Add gif functionality to images view #15

NoozAbooz opened this issue Nov 22, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@NoozAbooz
Copy link
Contributor

Maybe the image view could be expanded to a general-purpose view to support both images and gifs via the usage of gif-pros?

@unwieldycat
Copy link
Owner

Sounds great, will add that to my todo to investigate for a future minor update!

@unwieldycat unwieldycat added the enhancement New feature or request label Nov 23, 2023
@NoozAbooz
Copy link
Contributor Author

NoozAbooz commented May 24, 2024

Having done some basic testing, I found that https://github.com/theol0403/gif-pros is fully compatible with Robodash's view system. I could help write a PR to add a new GIF view to the template, but I'd like to hear your opinion on embedding gif-pros beforehand.

@unwieldycat
Copy link
Owner

I've held off on bundling gif-pros because of this PR on liblvgl, which enables LVGL's filesystem driver and gif/png/jpeg decoders. It's just been merged into liblvgl's master branch so it'll be in liblvgl's next release. If you'd like, you can create a gif-pros view template, but I don't think I'll be bundling gif-pros with robodash.

@NoozAbooz
Copy link
Contributor Author

Wow, I didn't even know liblvgl was going to include native graphics file rendering support. Since there wouldn't be any need for liblvgl now, I don't think a pr would be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants