refactor: simplify code

unit-mesh · Dec 7, 2023 · c4174ed · c4174ed
1 parent 96170aa
commit c4174ed
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/code-quality/src/main/kotlin/cc/unitmesh/quality/ExtRuleAnalyser.kt b/code-quality/src/main/kotlin/cc/unitmesh/quality/ExtRuleAnalyser.kt
@@ -9,8 +9,8 @@ import org.archguard.scanner.core.sourcecode.CodeDatabaseRelation
 import org.archguard.scanner.core.sourcecode.ContainerService
 
 class ExtRuleAnalyser {
-    val webApiRuleSetProvider = WebApiRuleSetProvider()
-    val sqlRuleSetProvider = SqlRuleSetProvider()
+    private val webApiRuleSetProvider = WebApiRuleSetProvider()
+    private val sqlRuleSetProvider = SqlRuleSetProvider()
 
     fun checkApi(services: List<ContainerService>): List<Issue> {
         return WebApiRuleVisitor(services).visitor(listOf(webApiRuleSetProvider.get()))

diff --git a/unit-picker/src/main/kotlin/cc/unitmesh/pick/picker/PickJob.kt b/unit-picker/src/main/kotlin/cc/unitmesh/pick/picker/PickJob.kt
@@ -1,11 +1,8 @@
 package cc.unitmesh.pick.picker
 
 import chapi.domain.core.CodeContainer
-import chapi.domain.core.CodeDataStruct
 import kotlinx.serialization.Serializable
-import kotlinx.serialization.Transient
 import org.archguard.scanner.analyser.count.FileJob
-import java.security.MessageDigest
 
 @Serializable
 class PickJob(

diff --git a/unit-picker/src/main/kotlin/cc/unitmesh/pick/worker/WorkerManager.kt b/unit-picker/src/main/kotlin/cc/unitmesh/pick/worker/WorkerManager.kt
@@ -5,7 +5,6 @@ import org.archguard.rule.common.Language
 
 class WorkerManager {
     private val workers: Map<Language, LangWorker> = mapOf(
-        // todo: add more language support
         Language.JAVA to JavaLangWorker(),
     )