refactor: extract analyser

code-quality/src/main/kotlin/cc/unitmesh/quality/ExtRuleAnalyser.kt

@@ -0,0 +1,5 @@
+package cc.unitmesh.quality
+
+class ExtRuleAnalyser {
+    // check with WebAPI, SQL or Other rule by ArchGuard
+}

code-quality/src/main/kotlin/cc/unitmesh/quality/BadSmellGraphCall.kt → code-quality/src/main/kotlin/cc/unitmesh/quality/badsmell/BadSmellGraphCall.kt

@@ -1,4 +1,4 @@
-package cc.unitmesh.quality
+package cc.unitmesh.quality.badsmell
 
 class BadSmellGraphCall {
     companion object {

code-quality/src/main/kotlin/cc/unitmesh/quality/badsmell/BadSmellModel.kt

@@ -0,0 +1,9 @@
+package cc.unitmesh.quality.badsmell
+
+data class BadSmellModel(
+    val file: String? = null,
+    val line: String? = null,
+    val bs: SmellType? = null,
+    val description: String? = null,
+    val size: Int? = null,
+)

code-quality/src/main/kotlin/cc/unitmesh/quality/BadsmellAnalyser.kt → code-quality/src/main/kotlin/cc/unitmesh/quality/badsmell/BadsmellAnalyser.kt

@@ -1,4 +1,4 @@
-package cc.unitmesh.quality
+package cc.unitmesh.quality.badsmell
 
 import chapi.domain.core.CodeDataStruct
 import chapi.domain.core.CodeFunction
@@ -9,35 +9,6 @@ private val CodeFunction.IfSize: Int get() = 0
 private val CodeFunction.SwitchSize: Int get() = 0
 private val CodeFunction.IfInfo: List<CodePosition> get() = listOf()
 
-data class BsConfig(
-    val bsLongParasLength: Int = 5,
-    val bsIfSwitchLength: Int = 8,
-    val bsLargeLength: Int = 20,
-    val bsMethodLength: Int = 30,
-    val bsIfLinesLength: Int = 3,
-)
-
-enum class SmellType {
-    SMELL_GARPH_CONNECTED_CALL,
-    SMELL_LAZY_ELEMENT,
-    SMELL_LONG_METHOD,
-    SMELL_DATA_CLASS,
-    SMELL_REFUSED_BEQUEST,
-    SMELL_LARGE_CLASS,
-    SMELL_COMPLEX_CONDITION,
-    SMELL_REPEATED_SWITCHES,
-    SMELL_LONG_PARAMETER_LIST
-}
-
-data class BadSmellModel(
-    val file: String? = null,
-    val line: String? = null,
-    val bs: SmellType? = null,
-    val description: String? = null,
-    val size: Int? = null,
-)
-
-
 class BadsmellAnalyser(val data: List<CodeDataStruct>, val bsConfig: BsConfig = BsConfig()) {
     fun analysis(): MutableList<BadSmellModel> {
         val badSmellList = mutableListOf<BadSmellModel>()

code-quality/src/main/kotlin/cc/unitmesh/quality/badsmell/BsConfig.kt

@@ -0,0 +1,9 @@
+package cc.unitmesh.quality.badsmell
+
+data class BsConfig(
+    val bsLongParasLength: Int = 5,
+    val bsIfSwitchLength: Int = 8,
+    val bsLargeLength: Int = 20,
+    val bsMethodLength: Int = 30,
+    val bsIfLinesLength: Int = 3,
+)

code-quality/src/main/kotlin/cc/unitmesh/quality/badsmell/SmellType.kt

@@ -0,0 +1,13 @@
+package cc.unitmesh.quality.badsmell
+
+enum class SmellType {
+    SMELL_GARPH_CONNECTED_CALL,
+    SMELL_LAZY_ELEMENT,
+    SMELL_LONG_METHOD,
+    SMELL_DATA_CLASS,
+    SMELL_REFUSED_BEQUEST,
+    SMELL_LARGE_CLASS,
+    SMELL_COMPLEX_CONDITION,
+    SMELL_REPEATED_SWITCHES,
+    SMELL_LONG_PARAMETER_LIST
+}

code-quality/src/main/kotlin/cc/unitmesh/quality/base/QualityAnalyser.kt

@@ -0,0 +1,5 @@
+package cc.unitmesh.quality.base
+
+interface QualityAnalyser {
+    fun analysis()
+}

code-quality/src/test/kotlin/cc/unitmesh/quality/BadsmellAnalyserTest.kt

@@ -1,5 +1,7 @@
 package cc.unitmesh.quality
 
+import cc.unitmesh.quality.badsmell.BadsmellAnalyser
+import cc.unitmesh.quality.badsmell.SmellType
 import chapi.ast.javaast.JavaAnalyser
 import org.junit.jupiter.api.Assertions.assertEquals
 import org.junit.jupiter.api.Disabled