Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeforeSwapDelta docs inconsistency #7

Open
GianfrancoBazzani opened this issue Aug 23, 2024 · 0 comments
Open

BeforeSwapDelta docs inconsistency #7

GianfrancoBazzani opened this issue Aug 23, 2024 · 0 comments

Comments

@GianfrancoBazzani
Copy link

- The `afterSwap` hook receives the `beforeSwapDelta` as a parameter.

This line in the docs states that the afterSwap hook receives the beforeSwapDelta as a parameter, but neither IHooks.sol nor BaseHook.sol shows such a parameter.

https://github.com/Uniswap/v4-core/blob/e8e63c87afb433b650c2387d6d839a239ee05653/src/interfaces/IHooks.sol#L120-L126
https://github.com/Uniswap/v4-periphery/blob/d325f82761b2b37daed44ca237382c83243b1a32/src/base/hooks/BaseHook.sol#L111-L117

@GianfrancoBazzani GianfrancoBazzani changed the title BeforeSwapDelta docs inconsistency. BeforeSwapDelta docs inconsistency Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant