Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTP marker events overwritten by follow on events #225

Open
liudude123 opened this issue Aug 28, 2018 · 0 comments
Open

RTP marker events overwritten by follow on events #225

liudude123 opened this issue Aug 28, 2018 · 0 comments
Assignees

Comments

@liudude123
Copy link

RTP event messages write to the same jitter buffer frame. so follow on events overwrite the marker events.
The result is that mpf_dtmf_detector_get_frame() will discard the event frame as it would not have the marker flag set.
The reason for the overwrite is that in mpf_jitter_buffer_event_write() subsequent update events with different duration from the marker event (code attached below):
/* an update */ if(named_event->duration < jb->event_write_update->duration) { /* ignore this update, it's something from the past, which makes no sense now */ return JB_OK; } else if(named_event->duration == jb->event_write_update->duration) {
This allows the update frame to overwrite the marker frame.
Wireshark trace of such a call is attached
wscap_20180821_01_dtmf1234567890.zip

@achaloyan achaloyan self-assigned this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants