Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Nostr-Key Import of Non-Standard Taproot Addresses #16

Open
dannydeezy opened this issue Apr 22, 2024 · 2 comments
Open

Comments

@dannydeezy
Copy link

Hi there - when ordinals first launched, I created a browser-extension wallet experience utilizing the client's Nostr Key (https://github.com/deezy-inc/deezy-place). Unfortunately we are no longer actively supporting this product, but many people still have ordinals on these wallets. We want them to be able to import their key into Unisat.

The problem is that in my lack of experience and haste of building, our wallets generated non-standard taproot addresses, and therefore the typical private key import/export does not work nicely. In particular, we use a raw public key instead of properly tweaking it, see the mess: https://github.com/deezy-inc/nosft-core/blob/e586d27256c41d91d46f229c6afee976dcae15e2/src/app/psbt.ts#L323

I was wondering - would Unisat team be open to us proposing an additional keyring type, something like nonstandard-taproot-keyring.ts (https://github.com/unisat-wallet/wallet-sdk/tree/master/src/keyring). We can write all the code and propose it both here and then in the unisat browser extension repo. If so, then all our users could safely migrate to unisat easily. We would suggest that this keyring type be hidden from new users, as it is not recommended - only for use of recovering existing assets.

Please let me know what you think - just wanted to check before our team started work on the proposed changes

@dannydeezy
Copy link
Author

dannydeezy commented Apr 22, 2024

Actually looking more closely, the better design may be to actually use simple-keyring but add a new address type - will make a proposed PR

@jaybny
Copy link

jaybny commented Aug 28, 2024

i just ran into this exact problem. bip341 tweaks are a mess, as there is no way to extract the nostr pubkey from tweaked addresses.

However, i believe it is possible to go from raw private keys to Tweaked private/public keys - so depending on what you are trying to do it may be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants