Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should have an option to ignore nonconflicting redundant lines #861

Open
eggrobin opened this issue Jun 7, 2024 · 1 comment
Open
Assignees

Comments

@eggrobin
Copy link
Member

eggrobin commented Jun 7, 2024

Our strategy for handling merge conflicts (previously: #444, #568, #583) is to ignore the conflict markers and interpret both branches. This is fine unless there is overlap between modified ranges, as happened to me recently while synchronizing #578; in that case, even if the overlap agrees, we need to manually merge ranges, which is error-prone (recall that we expect to have to juggle upwards of 50 of those PRs for a long time).

There are Merge objects passed around in PropertyParsingInfo, null in many places; we could replace those nulls with something that accepts consistent values, maybe behind a flag so we do that only when handling merge conflicts.

@eggrobin eggrobin self-assigned this Jun 7, 2024
@macchiati
Copy link
Member

Good idea. Could even do it for all dev versions that are regenerated, automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants