-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special linting for TSV tN Files #873
Comments
@jag3773 The tX converter part of the system that does the linting has been made to be independent of knowledge about Door43. You pass it a set of files to convert and it passes back the results. Even the manifest file for tN contains no link pointing to the version of UGNT that was used. So it either has to be hard-coded or passed in to the system somehow. Alternatively, it could be done in the preprocessor in the Door43 code but that's not ideal either. |
A nice thing would be to run this linter not only when tN has an update pushed, but also when UGNT has an update pushed. (Don't see an easy way to implement this though.) |
I think that we should make a constraint by convention to require that the Greek and Hebrew referenced in the OrigQuote field must be listed in the |
Yes, that would be the best way ahead I think. And for other reasons, I think that |
Ok, I done a first pass on this that processes both OT and NT quotes. See https://dev.door43.org/u/unfoldingWord/en_tn/master/ (which has Ruth and Ezra suppressed so more NT errors are shown). |
Story
As a tC user I want to see the correctly highlighted text so that I'm not confused when checking my translation.
Notes
The tN TSV files are structured in such a way that they are intended to quote the UGNT text in the
OrigQuote
field. During the linting process we should verify that all of the OrigQuote entries in the TSV file(s) match what is in the published version of the UGNT.I think the tC team has some code that may be useful to use here.
cc @benjore @mannycolon @richmahn @RoyalSix @PhotoNomad0 @RobH123
The text was updated successfully, but these errors were encountered: