Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Messages for Audio #172

Open
jag3773 opened this issue Dec 21, 2015 · 6 comments
Open

Verify Messages for Audio #172

jag3773 opened this issue Dec 21, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@jag3773
Copy link
Contributor

jag3773 commented Dec 21, 2015

There should be no verification icons/information for audio files. Right now both iOS and Android seem to indicate that the audio is not verified (failed verification), which is not the case. Would be much better to show no verification information for audio.

@jag3773 jag3773 added this to the 2.3.0 Release milestone Dec 21, 2015
@bknatterud
Copy link
Contributor

But what is the point of verification if we are not going to show it is failing?

@dwsolberg
Copy link

@jag3773 See Bryn's note. Right now, there is no signature for the files, which means they are not verified. There is no way for the app to distinguish between files that should have no signature and those that should (otherwise, one could easily fake verification by deleting the files).

@jag3773
Copy link
Contributor Author

jag3773 commented Dec 22, 2015

It is not failing, we are simply not signing mp3s. Disabling verification on mp3 files seems like a pretty small task.

@bknatterud
Copy link
Contributor

I don't think it is so much the size of the task as it is just not a good idea to have exceptions for verification. But maybe what you are suggesting is to disable all verification for audio files? Is what you are thinking?

@jag3773
Copy link
Contributor Author

jag3773 commented Jan 13, 2016

Yes, disable all verification for audio files.

@jag3773 jag3773 assigned GottaGetSwifty and unassigned jag3773 Jan 13, 2016
@jag3773 jag3773 removed the question label Jan 13, 2016
@GottaGetSwifty
Copy link
Contributor

Removed on android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants