Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2520] Fix close code constants #1699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2520] Fix close code constants #1699

wants to merge 1 commit into from

Conversation

Garmelon
Copy link

@Garmelon Garmelon commented Oct 27, 2024 •
edited by fl4via
Loading

Jira: https://issues.redhat.com/browse/UNDERTOW-2520

The values 1002 and 1003 were swapped compared to the RFC.

@baranowb baranowb changed the title Fix close code constants [UNDERTOW-2520] Fix close code constants Oct 30, 2024
@baranowb baranowb added bug fix Contains bug fix(es) waiting PR update Awaiting PR update(s) from contributor before merging under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review labels Oct 30, 2024
@baranowb
Copy link
Contributor

@Garmelon could you please update commit message to include ticket ID?

baranowb
baranowb approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@baranowb baranowb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://datatracker.ietf.org/doc/html/rfc6455#section-7.4.1

@Garmelon
[UNDERTOW-2520] Fix close code constants
93b305f 
The values 1002 and 1003 were swapped compared to the RFC.
@Garmelon Garmelon mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baranowb baranowb baranowb approved these changes

@fl4via fl4via fl4via approved these changes

@ropalka ropalka ropalka approved these changes

@jasondlee jasondlee Awaiting requested review from jasondlee

Assignees
No one assigned
Labels
bug fix Contains bug fix(es) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review waiting PR update Awaiting PR update(s) from contributor before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garmelon @baranowb @ropalka @fl4via