Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2431] Bump jboss-parent to 46, checkstyle and slightly upda… #1655

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2431] Bump jboss-parent to 46, checkstyle and slightly upda… #1655

wants to merge 1 commit into from

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Aug 22, 2024 •
edited
Loading

…te src to align with new rules
Issue: https://issues.redhat.com/browse/UNDERTOW-2431

On hold, this require release of new undertow-checkstyle and decision which approach will be better.
This PR assumes no change in config, hence "MAX" changes are required.

Alternative: #1654

@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels Aug 22, 2024
@baranowb baranowb mentioned this pull request Aug 22, 2024
Closed
@ropalka
Copy link
Contributor

ropalka commented Sep 11, 2024

This PR needs rebase so CI can run @baranowb

@fl4via
Copy link
Member

fl4via commented Sep 18, 2024

@baranowb FYI, I'll be looking into what is needed to release the checkstyles project so we can move forward with this PR.

@fl4via
Copy link
Member

fl4via commented Sep 18, 2024

ditto here #1654 I'm marking both as duplicates and linking the PRs so it can be clear that they are alternatives to the same issue

@fl4via fl4via added duplicate Duplicates other pull request(s) and removed waiting CI check Ready to be merged but waiting for CI check labels Sep 18, 2024
@fl4via fl4via removed duplicate Duplicates other pull request(s) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review labels Oct 4, 2024
@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) waiting peer review PRs that edit core classes might require an extra review labels Oct 4, 2024
@fl4via fl4via added failed CI Introduced new regession(s) during CI check and removed waiting peer review PRs that edit core classes might require an extra review labels Oct 4, 2024
@fl4via fl4via added waiting CI check Ready to be merged but waiting for CI check and removed failed CI Introduced new regession(s) during CI check labels Oct 21, 2024
@ropalka ropalka removed the waiting CI check Ready to be merged but waiting for CI check label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl4via fl4via fl4via approved these changes

@ropalka ropalka ropalka approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baranowb @ropalka @fl4via