Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support case-insensitive headers #10

Open
Andrea opened this issue Nov 12, 2018 · 2 comments
Open

support case-insensitive headers #10

Andrea opened this issue Nov 12, 2018 · 2 comments

Comments

@Andrea
Copy link

Andrea commented Nov 12, 2018

Hi there

I notice when there is different cases on the headers, the parsing will fail.
For example replace
RowReaderFixtures.testReader line
"Str".read[String],
with this line
"str".read[String],

and you will have 2 failing cases.

Probably needs some level of customisation or asume that the headers will have certain case.

@Andrea Andrea changed the title support case-insensitive headers headers support case-insensitive headers Nov 12, 2018
@davegurnell
Copy link
Collaborator

davegurnell commented Nov 13, 2018 via email

@d6y
Copy link
Collaborator

d6y commented Nov 13, 2018

TL;DR: 👍

I think:

  • Case insensitive makes sense when working with human-generated CSV. We want to be lenient in accepting what we're given.
  • For machine-generated CSV, it probably doesn't matter as the case isn't changing.
  • The least likely scenario is distinguishing between columns based on the case (I've not done a survey, so that's total guesswork).

So yes: case insensitive as a default sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants