Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyBinding registered at wrong time - kills dev workspaces #29

Open
Tslat opened this issue Dec 26, 2020 · 2 comments
Open

KeyBinding registered at wrong time - kills dev workspaces #29

Tslat opened this issue Dec 26, 2020 · 2 comments
Labels

Comments

@Tslat
Copy link

Tslat commented Dec 26, 2020

Hi there - just a heads up;
You're currently registering your keybinds in the constructor of ClientRenderHandler, as seen here:

This is somewhat ok, but it breaks development environments which contain your mod, and it shouldn't be done there anyway.
This happens because some dev runtimes don't actually let Minecraft assign an instance (such as datagen), which causes this line to NPE because it's being called when it shouldn't be.

Can you move this to FMLClientSetupEvent, where it should be?

I'd do a PR but I'm not able to do so currently due to being away from my main dev setup

@unascribed
Copy link
Owner

You should really be using the fork of this mod.

Will fix this Soon™. Learning the fork exists and how much more advanced it is than this version very quickly killed any interest I had in reviving it. (This is not a bad thing, but I merged the 1.16 port PR with the expectation of starting a serious dev push on this again, but it's basically already been done.)

@Tslat
Copy link
Author

Tslat commented Dec 26, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants