Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter authentication is no longer working. Microsoft needs docs update #1823

Open
EternallLight opened this issue Oct 13, 2024 · 2 comments

Comments

@EternallLight
Copy link

EternallLight commented Oct 13, 2024

Description

I've set up everything as closely as per insturctions, and when trying to authenticate with Twitter, I'm getting this at https://comments.mydomain.com/auth/twitter/login?from=https%3A%2F%2Fcomments.mydomain.com%2Fweb%2Fiframe.html%3FselfClose&site=reactlibs

{
  error: "failed to get request token"
}

After some local debugging, it appeared the Twitter retuns an error during the initial attempt of getting a token from it. I suppose it's been a while since someone checked on it.

Remark 42 is still using the Twitter icon instead of the new X icon. Probably something has changed besides the name, and surprising Twitter asked me for money for using their API whereas attempting to hide the "free" button.

Overall, I'm just letting you know that it's no longer working as expected.

Microsoft Issue

Besides Twitter, Microsoft authentication also didn't work from the start, failing with the request is not valid error.

This Stackoverflow answer helped me to get it rolling:

You can simply go to the portal Azure panel, open the Manifest section, and change the signInAudience's value from PersonalMicrosoftAccount to AzureADandPersonalMicrosoftAccount. If it doesn't exist, create both key and value.

I'd recommend to add this to the docs.

@EternallLight EternallLight changed the title Twitter authentication is no longer working Twitter authentication is no longer working. Microsoft needs docs update Oct 13, 2024
@umputun
Copy link
Owner

umputun commented Oct 13, 2024

From what I recall, Twitter (X) doesn't allow auth method remark42 is using for a couple of years. @paskal do you recall details?

@paskal
Copy link
Collaborator

paskal commented Oct 20, 2024

@EternallLight could you please update Microsoft auth instructions here and in go-pkgz/auth?

As for Twitter, last discussion on the topic was here and I don't think anyone figured out how to make it work. I think we should leave its support in case it works for someone, but deprecate the parameters and remove the mentions from documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants