Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on Windows #5

Open
oguzhand95 opened this issue Apr 30, 2021 · 2 comments
Open

Doesn't work on Windows #5

oguzhand95 opened this issue Apr 30, 2021 · 2 comments

Comments

@oguzhand95
Copy link

Windows version did not work because software tried to launch vi.
Tried to use --editor flag, but couldn't manage to utilize notepad.exe either.

@ulucinar
Copy link
Owner

ulucinar commented May 1, 2021

Hi @oguzhand95,
Thank you for reporting this. Currently, I don't have a Windows machine to troubleshoot this issue. But if I can get my hands on one, I will try to troubleshoot it, let you know.

Have a wonderful day!

@mprigge
Copy link

mprigge commented Mar 15, 2022

I ran into what I'm guessing is basically the same problem. Of course, windows systems don't ship with vi, so that won't work out of the box.

Specifying notepad as the editor (using -e notepad) seems like it would work (notepad opens with the resource), but then notepad itself gets in the way when you try to save the file. Notepad has a pathological need to a) not save files in appdata/local/temp and b) add a .txt extension when you do save. If you wrestle with it to save the file back in the original path that was opened so that the file that edit-status wrote is actually modified before the notepad process ends, everything works as expected.

If you have Visual Studio Code installed, this ends up being a much better experience. However, you do need to specify the -w/--wait flag. As suggested in the usage instructions in the README, setting the EDITOR or KUBE_EDITOR environment variable to code -w (assuming code is in the path) does the trick nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants