Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] version 3.15 #1583

Closed
ultrabug opened this issue Nov 25, 2018 · 4 comments
Closed

[RFC] version 3.15 #1583

ultrabug opened this issue Nov 25, 2018 · 4 comments
Assignees
Milestone

Comments

@ultrabug
Copy link
Owner

In version 3.15 I would like to propose this:

"That's all", plus any critical bug fix of course.

@ultrabug ultrabug added this to the 3.15 milestone Nov 25, 2018
@ultrabug ultrabug self-assigned this Nov 25, 2018
@maximbaz
Copy link
Contributor

maximbaz commented Nov 25, 2018

+ Resolution to #1439 🙏

Don't necessarily want to merge that PR as it is, but I want to be able to click on the module and see a notification with full output of the last execution, without making that module refresh because I just clicked on it. I tried to look into how to make this generic via core, but didn't think of anything good as I described in #1531 (comment).

UPDATE: hm, I realized now this was included in your first point to deal with all open PRs...

@lasers
Copy link
Contributor

lasers commented Nov 25, 2018

use the extended zen

I can close merge some PRs. If I merge taskwarrior: new module from scratch and systemd: new module from scratch, 3~ issues will be solved, but we will have formatter. Do you want me to go ahead with the easy ones first?

once merged, black all the modules (and thus all the repository)

I can close them instead if needed... because I made them for fun. \o/ I misread.

add core support for click events modifiers

I add py3-cmd --modifer option. https://github.com/ultrabug/py3status/compare/py3-click-modifiers

  • py3-cmd click --modifier Shift --modifier Mod1 xrandr

@lasers
Copy link
Contributor

lasers commented Nov 25, 2018

add core support for click events modifiers added in i3 v4.16

This seems to be already working... Just need to add py3-click-modifiers branch above.

Two options choices to pick...

  • py3-cmd click --modifier Shift --modifier Mod1 xrandr

OR

  • py3-cmd click --modifiers Shift+Mod1 xrandr # Split on +

@ultrabug
Copy link
Owner Author

use the extended zen from #1582 to close or rework on all open PR for modules

I think that we have applied our Zen very well, we're down to 7 open PRs

once merged, black all the modules (and thus all the repository)

Done + CI enforced

add core support for click events modifiers added in i3 v4.16: https://i3wm.org/docs/i3bar-protocol.html

Done by @lasers (thanks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants