Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple familes in ped file #45

Open
reedacartwright opened this issue Aug 7, 2015 · 0 comments
Open

Multiple familes in ped file #45

reedacartwright opened this issue Aug 7, 2015 · 0 comments
Assignees
@stevenhwu
Labels
bug Priority-Normal Type-Interface Type-Research
Milestone
Version 2.0

Comments

@reedacartwright
Copy link
Contributor

Ped files support multiple families. Our peeling algorithm supports multiple families. The construction of peeler can fail if the same name is in multiple families.
@reedacartwright reedacartwright added this to the Version 2.0 milestone Nov 2, 2015
@stevenhwu stevenhwu self-assigned this Oct 4, 2016
stevenhwu added a commit to stevenhwu/denovogear that referenced this issue Oct 4, 2016
@stevenhwu
Fix Issue ultimatesource#45 - Multiple familes in ped file
1caba64 
- Merge family ID and individual ID in `ped.h` to make id unique. Use an "unique/unusual/obscure" delimiter, `_F@I_`, to concatenate these two IDs, then everything will be unique in `table_`. The `id()` function take care of the rest.
  - A simple delimiter (`_`, `@` ...etc) is avoid to prevent the case that family name is something like `*f1@` or `*f1_`.
- Update related unittests.
@stevenhwu stevenhwu mentioned this issue Oct 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenhwu stevenhwu

Labels
bug Priority-Normal Type-Interface Type-Research
Projects
None yet
Milestone
Version 2.0
Development

Successfully merging a pull request may close this issue.

Fix #45 - Multiple familes in ped file stevenhwu/denovogear
2 participants
@reedacartwright @stevenhwu