Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why 414 and other question about DNG math #312

Open
pd3 opened this issue Sep 29, 2020 · 2 comments
Open

Why 414 and other question about DNG math #312

pd3 opened this issue Sep 29, 2020 · 2 comments

Comments

@pd3
Copy link

pd3 commented Sep 29, 2020

Hi, I was looking at the DNG math and the implementation and can't figure out where the 414 term in this expression https://github.com/ultimatesource/denovogear/blob/develop/src/dnm/makeLookup.cc#L260 comes from? The comment suggest that 414 is the number of all triallelic cases, but I don't think that is true, as there are 552 trio configurations with 3 alleles.

@reedacartwright
Copy link
Contributor

Honestly, I don't know. At this point the DNM code is over ten years old, and the people who developed the model haven't been active with DNG development for years.

@pd3 pd3 changed the title Why 414? Why 414 and other question about DNG math Sep 30, 2020
@pd3
Copy link
Author

pd3 commented Sep 30, 2020

Thank you. I am adding more questions in case someone could explain:

For male chrX inheritance there are incorrect priors assigned, I believe they are simply bugs in the code. So far I discovered these three:

  • The transmission probability P(0/1 + 0 -> 0) should be equal to P(0/1 + 0 -> 1). Both should be 0.5, however the code evaluates one to 0.5 and the other to 1
  • The prior probability P(0/0 + 0 -> 0) should be equal to P(0/0 + 1 -> 0), father's genotype should be irrelevant
  • Similarly, P(0/1 + 1 -> 1) should be equal to P(0/1 + 0 -> 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants