Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

figure how to preserve the window object (specifically window.document) after iframe is removed from parent with JSDOM #29

Open
uladkasach opened this issue Mar 16, 2018 · 1 comment
Open

figure how to preserve the window object (specifically window.document) after iframe is removed from parent with JSDOM #29

uladkasach opened this issue Mar 16, 2018 · 1 comment

Comments

@uladkasach
Copy link
Owner

In browser context, removing iframe from parent does not corrupt the window object that scripts have access to inside of the loaded context.

In node context - with jsdom - the document and _location properties no longer exist after the parent is removed.
@uladkasach uladkasach reopened this Mar 16, 2018
@uladkasach
Copy link
Owner Author

c088b67 is only a hacky fix that needs a full solution

uladkasach added a commit that referenced this issue Mar 17, 2018
@uladkasach
keep bundle in npm package - and save part of the change for the #29 …
7b82dc4 
…change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uladkasach