Fixed an error that ignored baseURL #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the PR, I'll take a look as soon as I can |
|
@Tibing We need to make a release with baseURL enabled ASAP, can you take a look at this PR? |
|
Hi, sorry for the delayed response! Could you please provide a bit more detail about the refactoring you're doing here?
|
Tibing
requested changes
May 29, 2024
Comment on lines
+54
to
+66
| const lowercasedUrl = config.url.toLowerCase(); | ||
| const lowercasedBaseURL = config.baseURL?.toLowerCase(); | ||
|
|
||
| let url:URL; | ||
| if (lowercasedUrl.startsWith('http:') || lowercasedUrl.startsWith('https:')) { | ||
| // config.url has a higher priority than config.baseURL | ||
| url = new URL(config.url); | ||
| } else if (config.baseURL && (lowercasedBaseURL.startsWith('http:') || lowercasedBaseURL.startsWith('https:'))) { | ||
| url = new URL(config.baseURL + config.url); | ||
| } else { | ||
| // failed to find a valid url | ||
| throw new Error('Invalid URL: ' + config.url + ' or baseURL: ' + config.baseURL); | ||
| } |
There was a problem hiding this comment.
This logic should reside in a separate method or something like that
| const lowercasedUrl = config.url.toLowerCase(); | ||
| const lowercasedBaseURL = config.baseURL?.toLowerCase(); | ||
|
|
||
| let url:URL; |
There was a problem hiding this comment.
Suggested change
| let url:URL; | |
| let url: URL; |
| url = new URL(config.baseURL + config.url); | ||
| } else { | ||
| // failed to find a valid url | ||
| throw new Error('Invalid URL: ' + config.url + ' or baseURL: ' + config.baseURL); |
There was a problem hiding this comment.
this method is not intended to throw an error, it should return false http2 not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Tibing
I found your library very useful, but has a small issue when axios is configured to use
baseURL. Please take a look at this PR.Best regards,
Tonny