diff --git a/.gitignore b/.gitignore index f2bb5c445..82ba5f5bc 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,6 @@ +# Private folders +_ + # Ignore Mac files .DS_Store diff --git a/packages/ui5-middleware-approuter/test/auth/ui5-auth-in-yaml.yaml b/packages/ui5-middleware-approuter/test/auth/ui5-auth-in-yaml.yaml index bb16e95d4..89e9ef492 100644 --- a/packages/ui5-middleware-approuter/test/auth/ui5-auth-in-yaml.yaml +++ b/packages/ui5-middleware-approuter/test/auth/ui5-auth-in-yaml.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/auth/ui5-with-localDir.yaml b/packages/ui5-middleware-approuter/test/auth/ui5-with-localDir.yaml index 2f392bd6b..133b5575c 100644 --- a/packages/ui5-middleware-approuter/test/auth/ui5-with-localDir.yaml +++ b/packages/ui5-middleware-approuter/test/auth/ui5-with-localDir.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/crud/ui5.yaml b/packages/ui5-middleware-approuter/test/crud/ui5.yaml index a9773238c..723839d09 100644 --- a/packages/ui5-middleware-approuter/test/crud/ui5.yaml +++ b/packages/ui5-middleware-approuter/test/crud/ui5.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/dest-in-env/ui5.yaml b/packages/ui5-middleware-approuter/test/dest-in-env/ui5.yaml index aca2473f5..60252873c 100644 --- a/packages/ui5-middleware-approuter/test/dest-in-env/ui5.yaml +++ b/packages/ui5-middleware-approuter/test/dest-in-env/ui5.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/multitenant/ui5-auth-multitenant.yaml b/packages/ui5-middleware-approuter/test/multitenant/ui5-auth-multitenant.yaml index f6bf3bb01..261d1fa32 100644 --- a/packages/ui5-middleware-approuter/test/multitenant/ui5-auth-multitenant.yaml +++ b/packages/ui5-middleware-approuter/test/multitenant/ui5-auth-multitenant.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/no-auth/ui5-no-auth-in-yaml.yaml b/packages/ui5-middleware-approuter/test/no-auth/ui5-no-auth-in-yaml.yaml index a9773238c..723839d09 100644 --- a/packages/ui5-middleware-approuter/test/no-auth/ui5-no-auth-in-yaml.yaml +++ b/packages/ui5-middleware-approuter/test/no-auth/ui5-no-auth-in-yaml.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/no-auth/ui5.yaml b/packages/ui5-middleware-approuter/test/no-auth/ui5.yaml index a9773238c..723839d09 100644 --- a/packages/ui5-middleware-approuter/test/no-auth/ui5.yaml +++ b/packages/ui5-middleware-approuter/test/no-auth/ui5.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/options/ui5-no-config.yaml b/packages/ui5-middleware-approuter/test/options/ui5-no-config.yaml index a017fb5be..656d70f7b 100644 --- a/packages/ui5-middleware-approuter/test/options/ui5-no-config.yaml +++ b/packages/ui5-middleware-approuter/test/options/ui5-no-config.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/options/ui5-some-config.yaml b/packages/ui5-middleware-approuter/test/options/ui5-some-config.yaml index a2771bae8..974935e55 100644 --- a/packages/ui5-middleware-approuter/test/options/ui5-some-config.yaml +++ b/packages/ui5-middleware-approuter/test/options/ui5-some-config.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-disabled.yaml b/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-disabled.yaml index 2632681ba..2011fc283 100644 --- a/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-disabled.yaml +++ b/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-disabled.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-partial.yaml b/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-partial.yaml index 6e23fc599..64051f280 100644 --- a/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-partial.yaml +++ b/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-partial.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-approuter/test/rewrite/ui5.yaml b/packages/ui5-middleware-approuter/test/rewrite/ui5.yaml index 7e44bb8d2..6e041c063 100644 --- a/packages/ui5-middleware-approuter/test/rewrite/ui5.yaml +++ b/packages/ui5-middleware-approuter/test/rewrite/ui5.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-onelogin/sample/example_embeddedflp/ui5.yaml b/packages/ui5-middleware-onelogin/sample/example_embeddedflp/ui5.yaml index d80420fd0..9ad192e1c 100644 --- a/packages/ui5-middleware-onelogin/sample/example_embeddedflp/ui5.yaml +++ b/packages/ui5-middleware-onelogin/sample/example_embeddedflp/ui5.yaml @@ -9,7 +9,7 @@ resources: framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-middleware-onelogin/sample/example_simpleproxy_and_onelogin/ui5.yaml b/packages/ui5-middleware-onelogin/sample/example_simpleproxy_and_onelogin/ui5.yaml index d0b982cbd..9e4dfb93b 100644 --- a/packages/ui5-middleware-onelogin/sample/example_simpleproxy_and_onelogin/ui5.yaml +++ b/packages/ui5-middleware-onelogin/sample/example_simpleproxy_and_onelogin/ui5.yaml @@ -9,7 +9,7 @@ resources: framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-cachebuster/test/__assets__/ui5.basic.yaml b/packages/ui5-task-cachebuster/test/__assets__/ui5.basic.yaml index a6d42b1d8..504af71eb 100644 --- a/packages/ui5-task-cachebuster/test/__assets__/ui5.basic.yaml +++ b/packages/ui5-task-cachebuster/test/__assets__/ui5.basic.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-cachebuster/test/__assets__/ui5.noExcluded.yaml b/packages/ui5-task-cachebuster/test/__assets__/ui5.noExcluded.yaml index cfd170bf6..b107d3a5d 100644 --- a/packages/ui5-task-cachebuster/test/__assets__/ui5.noExcluded.yaml +++ b/packages/ui5-task-cachebuster/test/__assets__/ui5.noExcluded.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyIndex.yaml b/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyIndex.yaml index 073d7f20a..7ad71d51c 100644 --- a/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyIndex.yaml +++ b/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyIndex.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyMove.yaml b/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyMove.yaml index c4e4dca04..7a800e4a3 100644 --- a/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyMove.yaml +++ b/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyMove.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.file-alt.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.file-alt.yaml index 3abee2911..55b4ef26a 100644 --- a/packages/ui5-task-copyright/test/__assets__/ui5.file-alt.yaml +++ b/packages/ui5-task-copyright/test/__assets__/ui5.file-alt.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.file-env.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.file-env.yaml index 83f7ba299..01bbce712 100644 --- a/packages/ui5-task-copyright/test/__assets__/ui5.file-env.yaml +++ b/packages/ui5-task-copyright/test/__assets__/ui5.file-env.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.file.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.file.yaml index d2ff21e23..527b267ac 100644 --- a/packages/ui5-task-copyright/test/__assets__/ui5.file.yaml +++ b/packages/ui5-task-copyright/test/__assets__/ui5.file.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.inline-altyear.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.inline-altyear.yaml index dc440988d..07a87f2ce 100644 --- a/packages/ui5-task-copyright/test/__assets__/ui5.inline-altyear.yaml +++ b/packages/ui5-task-copyright/test/__assets__/ui5.inline-altyear.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.inline.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.inline.yaml index bf30ff28e..15165fa17 100644 --- a/packages/ui5-task-copyright/test/__assets__/ui5.inline.yaml +++ b/packages/ui5-task-copyright/test/__assets__/ui5.inline.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.no.copyright.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.no.copyright.yaml index 83f7ba299..01bbce712 100644 --- a/packages/ui5-task-copyright/test/__assets__/ui5.no.copyright.yaml +++ b/packages/ui5-task-copyright/test/__assets__/ui5.no.copyright.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeShims.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeShims.yaml index a490ac3fd..88ee93563 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeShims.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeShims.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeSomeDeps.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeSomeDeps.yaml index ca9210e55..3d801c674 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeSomeDeps.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeSomeDeps.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFiles.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFiles.yaml index e716b272c..fdbdfded6 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFiles.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFiles.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFilesMap.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFilesMap.yaml index 797b43d97..f65db8ce1 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFilesMap.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFilesMap.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.basic.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.basic.yaml index 97d98f135..4839b3c1b 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.basic.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.basic.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.customZipName.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.customZipName.yaml index 048509332..4def7f6e7 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.customZipName.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.customZipName.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeDeps.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeDeps.yaml index 198856391..abb3b56a0 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeDeps.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeDeps.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeSomeDeps.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeSomeDeps.yaml index 90935bc08..0e9e52e7f 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeSomeDeps.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeSomeDeps.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.onlyZip.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.onlyZip.yaml index 1e77a2417..a0e070e1a 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.onlyZip.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.onlyZip.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.relativePaths.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.relativePaths.yaml index d551b1a41..7720acb9d 100644 --- a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.relativePaths.yaml +++ b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.relativePaths.yaml @@ -4,7 +4,7 @@ metadata: type: application framework: name: OpenUI5 - version: "1.127.0" + version: "1.129.0" libraries: - name: sap.m - name: sap.ui.core diff --git a/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents-base.js b/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents-base.js index 6e6b2eb69..f67e1ee39 100644 --- a/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents-base.js +++ b/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents-base.js @@ -1,44 +1,4 @@ -sap.ui.define(['sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer', 'sap/ui/base/DataType'], (function (hyphenate, WebComponentRenderer, DataType) { 'use strict'; - - // Fixed with https://github.com/SAP/openui5/commit/7a4615e3fe55221ae9de9d876d3eed209f71a5b1 in UI5 1.128.0 - - - WebComponentRenderer.renderAttributeProperties = function (oRm, oWebComponent) { - var oAttrProperties = oWebComponent.getMetadata().getPropertiesByMapping("property"); - // ##### MODIFICATION START ##### - var aPropsToAlwaysSet = ["enabled"].concat( - Object.entries(oWebComponent.getMetadata().getPropertyDefaults()).map(([key, value]) => { - return value !== undefined && value !== false ? key : null; - }) - ); // some properties can be initial and still have a non-default value due to side effects (e.g. EnabledPropagator) - // ##### MODIFICATION END ##### - for (var sPropName in oAttrProperties) { - if (oWebComponent.isPropertyInitial(sPropName) && !aPropsToAlwaysSet.includes(sPropName)) { - continue; // do not set attributes for properties that were not explicitly set or bound - } - - var oPropData = oAttrProperties[sPropName]; - var vPropValue = oPropData.get(oWebComponent); - if (oPropData.type === "object" || typeof vPropValue === "object") { - continue; // Properties of type "object" and custom-type properties with object values are set during onAfterRendering - } - - var sAttrName = oPropData._sMapTo ? oPropData._sMapTo : hyphenate(sPropName); - if (oPropData._fnMappingFormatter) { - vPropValue = oWebComponent[oPropData._fnMappingFormatter].call(oWebComponent, vPropValue); - } - - if (oPropData.type === "boolean") { - if (vPropValue) { - oRm.attr(sAttrName, ""); - } - } else { - if (vPropValue != null) { - oRm.attr(sAttrName, vPropValue); - } - } - } - }; +sap.ui.define(['sap/ui/base/DataType'], (function (DataType) { 'use strict'; const pkg = { "_ui5metadata": { diff --git a/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents.js b/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents.js index 32679f63d..19976a456 100644 --- a/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents.js +++ b/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents.js @@ -1,4 +1,4 @@ -sap.ui.define(['sap/ui/base/DataType', './webcomponents-base', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer'], (function (DataType, _ui5_webcomponentsBase, hyphenate, WebComponentRenderer) { 'use strict'; +sap.ui.define(['sap/ui/base/DataType', './webcomponents-base'], (function (DataType, _ui5_webcomponentsBase) { 'use strict'; const pkg = { "_ui5metadata": { diff --git a/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents/dist/CheckBox.js b/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents/dist/CheckBox.js index ba2d30afe..c9e78583f 100644 --- a/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents/dist/CheckBox.js +++ b/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents/dist/CheckBox.js @@ -1,4 +1,4 @@ -sap.ui.define(['ui5/ecosystem/demo/app/resources/@ui5/webcomponents', 'sap/ui/core/webc/WebComponent', 'sap/ui/base/DataType', 'ui5/ecosystem/demo/app/resources/@ui5/webcomponents-base', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer'], (function (_ui5_webcomponents, WebComponentBaseClass, DataType, _ui5_webcomponentsBase, hyphenate, WebComponentRenderer) { 'use strict'; +sap.ui.define(['ui5/ecosystem/demo/app/resources/@ui5/webcomponents', 'sap/ui/core/webc/WebComponent', 'sap/ui/base/DataType', 'ui5/ecosystem/demo/app/resources/@ui5/webcomponents-base'], (function (_ui5_webcomponents, WebComponentBaseClass, DataType, _ui5_webcomponentsBase) { 'use strict'; const isSSR$2 = typeof document === "undefined"; const internals = { diff --git a/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents.js b/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents.js index c311fe03c..ca7c00375 100644 --- a/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents.js +++ b/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents.js @@ -1,4 +1,4 @@ -sap.ui.define(['sap/ui/base/DataType', '../webcomponents-base', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer'], (function (DataType, _ui5_webcomponentsBase, hyphenate, WebComponentRenderer) { 'use strict'; +sap.ui.define(['sap/ui/base/DataType', '../webcomponents-base'], (function (DataType, _ui5_webcomponentsBase) { 'use strict'; const pkg = { "_ui5metadata": { diff --git a/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents/dist/Panel.js b/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents/dist/Panel.js index cd8931fdc..5eb99bb18 100644 --- a/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents/dist/Panel.js +++ b/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents/dist/Panel.js @@ -1,4 +1,4 @@ -sap.ui.define(['ui5/ecosystem/demo/app/resources/webcomponents-base', 'ui5/ecosystem/demo/app/resources/@ui5/webcomponents', 'sap/ui/core/webc/WebComponent', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer', 'sap/ui/base/DataType'], (function (_ui5_webcomponentsBase, _ui5_webcomponents, WebComponentBaseClass, hyphenate, WebComponentRenderer, DataType) { 'use strict'; +sap.ui.define(['ui5/ecosystem/demo/app/resources/webcomponents-base', 'ui5/ecosystem/demo/app/resources/@ui5/webcomponents', 'sap/ui/core/webc/WebComponent', 'sap/ui/base/DataType'], (function (_ui5_webcomponentsBase, _ui5_webcomponents, WebComponentBaseClass, DataType) { 'use strict'; const kebabToCamelMap = new Map(); const camelToKebabMap = new Map(); diff --git a/packages/ui5-tooling-modules/test/__snap__/d726ec84/webcomponents-base.js b/packages/ui5-tooling-modules/test/__snap__/d726ec84/webcomponents-base.js index 9742db2c3..71e7c0757 100644 --- a/packages/ui5-tooling-modules/test/__snap__/d726ec84/webcomponents-base.js +++ b/packages/ui5-tooling-modules/test/__snap__/d726ec84/webcomponents-base.js @@ -1,4 +1,4 @@ -sap.ui.define(['exports', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer', 'sap/ui/base/DataType'], (function (exports, hyphenate, WebComponentRenderer, DataType) { 'use strict'; +sap.ui.define(['exports', 'sap/ui/base/DataType'], (function (exports, DataType) { 'use strict'; var class2type = {}; var hasOwn = class2type.hasOwnProperty; @@ -1569,45 +1569,6 @@ sap.ui.define(['exports', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebCom LitStatic.unsafeStatic = o; registerFeature("LitStatic", LitStatic); - // Fixed with https://github.com/SAP/openui5/commit/7a4615e3fe55221ae9de9d876d3eed209f71a5b1 in UI5 1.128.0 - - - WebComponentRenderer.renderAttributeProperties = function (oRm, oWebComponent) { - var oAttrProperties = oWebComponent.getMetadata().getPropertiesByMapping("property"); - // ##### MODIFICATION START ##### - var aPropsToAlwaysSet = ["enabled"].concat( - Object.entries(oWebComponent.getMetadata().getPropertyDefaults()).map(([key, value]) => { - return value !== undefined && value !== false ? key : null; - }) - ); // some properties can be initial and still have a non-default value due to side effects (e.g. EnabledPropagator) - // ##### MODIFICATION END ##### - for (var sPropName in oAttrProperties) { - if (oWebComponent.isPropertyInitial(sPropName) && !aPropsToAlwaysSet.includes(sPropName)) { - continue; // do not set attributes for properties that were not explicitly set or bound - } - - var oPropData = oAttrProperties[sPropName]; - var vPropValue = oPropData.get(oWebComponent); - if (oPropData.type === "object" || typeof vPropValue === "object") { - continue; // Properties of type "object" and custom-type properties with object values are set during onAfterRendering - } - - var sAttrName = oPropData._sMapTo ? oPropData._sMapTo : hyphenate(sPropName); - if (oPropData._fnMappingFormatter) { - vPropValue = oWebComponent[oPropData._fnMappingFormatter].call(oWebComponent, vPropValue); - } - - if (oPropData.type === "boolean") { - if (vPropValue) { - oRm.attr(sAttrName, ""); - } - } else { - if (vPropValue != null) { - oRm.attr(sAttrName, vPropValue); - } - } - } - }; setCustomElementsScopingSuffix("mYsCoPeSuFfIx"); const pkg = { diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 798dc2e40..8ab19357d 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -1028,8 +1028,8 @@ importers: specifier: ^3.4.2 version: 3.4.2 '@types/openui5': - specifier: 1.127.0 - version: 1.127.0 + specifier: 1.129.0 + version: 1.129.0 '@ui5/cli': specifier: ^4.0.6 version: 4.0.6 @@ -1082,8 +1082,8 @@ importers: showcases/ui5-tsapp-simple: devDependencies: '@types/openui5': - specifier: 1.127.0 - version: 1.127.0 + specifier: 1.129.0 + version: 1.129.0 '@ui5/cli': specifier: ^4.0.6 version: 4.0.6 @@ -1122,8 +1122,8 @@ importers: version: 2.1.2 devDependencies: '@types/openui5': - specifier: 1.127.0 - version: 1.127.0 + specifier: 1.129.0 + version: 1.129.0 '@ui5/cli': specifier: ^4.0.6 version: 4.0.6 @@ -1158,8 +1158,8 @@ importers: showcases/ui5-tslib: devDependencies: '@types/openui5': - specifier: 1.127.0 - version: 1.127.0 + specifier: 1.129.0 + version: 1.129.0 '@ui5/cli': specifier: ^4.0.6 version: 4.0.6 @@ -2946,8 +2946,8 @@ packages: '@types/normalize-package-data@2.4.4': resolution: {integrity: sha512-37i+OaWTh9qeK4LSHPsyRC7NahnGotNuZvjLSgcPzblpHB3rrCJxAOgI5gCdKm7coonsaX1Of0ILiTcnZjbfxA==} - '@types/openui5@1.127.0': - resolution: {integrity: sha512-MIauyuHgaNnN7PDMZ71vS9XqpVlo0tXL6EaMhdmNjQTMblm6IJxlmOz0UX1BkdJwGKIA2rVE+2WGz6xn7ndJaQ==} + '@types/openui5@1.129.0': + resolution: {integrity: sha512-OLh8+uOAd0Qq6BiDRy2NnIeKMrwHwdSBi9YGwalU0xLQxZav2G6lYcP8nMOs61Z4aCE+Ae5sEjYoCizJ+fqJ6g==} '@types/phoenix@1.6.5': resolution: {integrity: sha512-xegpDuR+z0UqG9fwHqNoy3rI7JDlvaPh2TY47Fl80oq6g+hXT+c/LEuE43X48clZ6lOfANl5WrPur9fYO1RJ/w==} @@ -12010,7 +12010,7 @@ snapshots: '@types/normalize-package-data@2.4.4': {} - '@types/openui5@1.127.0': + '@types/openui5@1.129.0': dependencies: '@types/jquery': 3.5.30 '@types/qunit': 2.19.10 @@ -12502,7 +12502,7 @@ snapshots: '@ui5/webcomponents-localization@2.1.2': dependencies: - '@types/openui5': 1.127.0 + '@types/openui5': 1.129.0 '@ui5/webcomponents-base': 2.1.2 '@ui5/webcomponents-theming@2.1.2': diff --git a/showcases/approuter/webapp/index.html b/showcases/approuter/webapp/index.html index 01dd7748d..17b8555e6 100644 --- a/showcases/approuter/webapp/index.html +++ b/showcases/approuter/webapp/index.html @@ -49,7 +49,7 @@ - +