Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recombine - sorting directories ilkely fails with different drives #69

Open
uglygus opened this issue Jun 27, 2021 · 4 comments
Open

recombine - sorting directories ilkely fails with different drives #69

uglygus opened this issue Jun 27, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@uglygus
Copy link
Owner

uglygus commented Jun 27, 2021

Sorting directories is currently based on absolute paths so dirs from different trees will not necessarily be recombined in the correct order.

@uglygus uglygus added the bug Something isn't working label Jun 27, 2021
@charles1997
Copy link
Collaborator

Is this causing me to have this error?

sorted_listdir
names = os.listdir(directory)
FileNotFoundError: [Errno 2] No such file or directory: ''

@uglygus
Copy link
Owner Author

uglygus commented Jun 28, 2021

Probably not unless the two things you are recombining are on different drives. I am working on recombine right now. If you send me the full stacktrace. (Everythin after it crashes.) It will have filenames and filenumbers.

@charles1997
Copy link
Collaborator

charleslinux@charlesdesktop01:/mnt/c/Users/charles xu$ recombine /mnt/l/summer2021/recombine_jpg '/mnt/l/summer2021/recombine_jpg - Copy' /mnt/l/summer2021/dst-enfused
len(src_dirs)= 3
recombine: src_dirs= ['/mnt/l/summer2021/recombine_jpg', '/mnt/l/summer2021/recombine_jpg - Copy', '/mnt/l/summer2021/dst-enfused']
trimmed_items=['', '', '']
trimmed_items=['', '', '']
recombine: src_dirs= ['', '', '']
new_basename =
new_basename =
dst_dir=''
Traceback (most recent call last):
File "/home/charleslinux/.local/bin/recombine", line 11, in
load_entry_point('frameoverframe', 'console_scripts', 'recombine')()
File "/mnt/l/summer2021/frameoverframe/frameoverframe/cli/recombine__main__.py", line 96, in main
recombine(
File "/mnt/l/summer2021/frameoverframe/frameoverframe/recombine.py", line 97, in recombine
item_count += len(sorted_listdir(directory))
File "/mnt/l/summer2021/frameoverframe/frameoverframe/utils.py", line 119, in sorted_listdir
names = os.listdir(directory)
FileNotFoundError: [Errno 2] No such file or directory: ''

@uglygus
Copy link
Owner Author

uglygus commented Jun 30, 2021

Posssibly fixed by #70

@charles1997 Can you grab the latest and try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants