Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization of ccpp-physics #2035

Merged
merged 67 commits into from
Jan 4, 2024

Conversation

dustinswales
Copy link
Collaborator

@dustinswales dustinswales commented Dec 14, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG: /scratch1/BMC/gmtb/Dustin.Swales/UFS/reorg_phys/ufs-weather-model/tests/logs/RegressionTests_hera.log
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Reorganization of the ccpp-physics repository, and upstream dependencies.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

N/A

Commit Message

This PR contains changes to the CCPP prebuild step to accommodate a reorganization of the ccpp-physics repository.

  • Re-organization of physical parameterizations into process and scheme subdirectories
  • Modifications to CCPP metadata files to accommodate source file location changes
  • File location update referenced in CMEPS
  • No changes to the results are introduced here, only to file locations.

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

No changes to baselines or input data needed.

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@zach1221
Copy link
Collaborator

zach1221 commented Jan 3, 2024

Seems there is some serious slowness on Orion. Some of the cases are just failing in the queue. I will report the issue, however it may be best to skip Orion for this PR.

@zach1221 zach1221 removed the hercules-RT Run Hera regression testing label Jan 3, 2024
@zach1221
Copy link
Collaborator

zach1221 commented Jan 3, 2024

Ok Orion seems to be good now. I think we can begin the merge process now.

@zach1221
Copy link
Collaborator

zach1221 commented Jan 3, 2024

@dustinswales CMEPS PR#103 is merged. Please revert changes in .gitmodule url and update submodule hash: NOAA-EMC/CMEPS@f8f7ba7

@zach1221
Copy link
Collaborator

zach1221 commented Jan 3, 2024

@dustinswales fv3atm is now merged as well. Hash: NOAA-EMC/fv3atm@997907f

Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Commit message should use github linking to issues related to these changes (whether or not they are in UFSWM). Please update it. Let me know if I can help clarify anything.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jan 4, 2024

The Commit message should use github linking to issues related to these changes (whether or not they are in UFSWM). Please update it. Let me know if I can help clarify anything.

@BrianCurtis-NOAA Commit messages were updated.

@jkbk2004 jkbk2004 merged commit 407c6fd into ufs-community:develop Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants