Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Port SRW to Gaea C6 #1163

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

[develop] Port SRW to Gaea C6 #1163

wants to merge 8 commits into from

Conversation

RatkoVasic-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA commented Dec 4, 2024 •
edited
Loading

DESCRIPTION OF CHANGES:

Enable SRW for new machine Gaea-C6

NOTE1: needs to update SRW to new UFS-WM version (after PR2448)
NOTE2: on Gaea C6 for tests use account bil-fire8, not epic, i.e. ./run_WE2E_tests.py -t fundamental -m gaea-c6 -a bil-fire8

UFS_SRW_data copied to /gpfs/f6/bil-fire8/world-shared/UFS_SRW_data location.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (updated in this PR)

TESTS CONDUCTED:

  • derecho.intel
  • gaea-c5.intel
  • gaea-c6.intel - comprehensive
  • hera.gnu
  • hera.intel
  • hercules.intel
  • jet.intel
  • orion.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

  • ufs-community/ufs-weather-model/pull/2448 Issue: #2407

DOCUMENTATION:

rst files updated.

ISSUE:

Closes issue #1120

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

@MichaelLueken MichaelLueken linked an issue Dec 4, 2024 that may be closed by this pull request
Enable SRW on Gaea-C6 #1120
Open
@MichaelLueken MichaelLueken added enhancement New feature or request Work in Progress labels Dec 4, 2024
@RatkoVasic-NOAA
Copy link
Collaborator Author

Passed comprehensive tests:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
2020_CAD_20241204002937                                            COMPLETE              41.87
2020_CAPE_20241204003011                                           COMPLETE              43.16
2019_hurricane_barry_20241204003011                                COMPLETE              41.60
2019_halloween_storm_20241204003012                                COMPLETE              53.42
2019_hurricane_lorenzo_20241204003012                              COMPLETE              48.37
2019_memorial_day_heat_wave_20241204003013                         COMPLETE              50.84
2020_denver_radiation_inversion_20241204003014                     COMPLETE              41.79
2020_easter_storm_20241204003014                                   COMPLETE              42.76
2020_jan_cold_blast_20241204003015                                 COMPLETE              44.63
community_20241204003015                                           COMPLETE              24.79
custom_ESGgrid_20241204003016                                      COMPLETE              30.05
custom_ESGgrid_Central_Asia_3km_20241204003016                     COMPLETE              33.77
custom_ESGgrid_IndianOcean_6km_20241204003017                      COMPLETE              23.92
custom_ESGgrid_NewZealand_3km_20241204003017                       COMPLETE              88.16
custom_ESGgrid_Peru_12km_20241204003056                            COMPLETE              27.01
custom_ESGgrid_SF_1p1km_20241204003057                             COMPLETE             262.59
custom_GFDLgrid__GFDLgrid_USE_NUM_CELLS_IN_FILENAMES_eq_FALSE_202  COMPLETE              10.53
custom_GFDLgrid_20241204003132                                     COMPLETE               9.44
deactivate_tasks_20241204003132                                    COMPLETE               1.13
get_from_AWS_ics_GEFS_lbcs_GEFS_fmt_grib2_2022040400_ensemble_2me  COMPLETE             974.46
get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS_20241204003133              COMPLETE              13.86
grid_CONUS_25km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_202  COMPLETE               9.39
grid_CONUS_3km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_  COMPLETE             377.41
grid_RRFS_AK_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20241  COMPLETE             138.34
grid_RRFS_AK_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_20241204003210  COMPLETE             267.88
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241204003  COMPLETE              45.10
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20  COMPLETE              50.35
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2024120400  COMPLETE              55.12
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_202  COMPLETE              74.02
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               6.27
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20  COMPLETE              22.12
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              18.96
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2024120400  COMPLETE              18.61
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241204003  COMPLETE              54.79
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_202  COMPLETE              23.36
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_RAP_20241204003217  COMPLETE              13.82
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2_20241  COMPLETE               9.88
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024120400321  COMPLETE              42.45
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_RRFS_v1beta_202412040  COMPLETE              19.51
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_202412  COMPLETE             319.71
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE             485.13
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_20241204  COMPLETE             497.48
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_20241204003  COMPLETE             511.55
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_2024  COMPLETE             510.44
grid_RRFS_CONUScompact_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_  COMPLETE              41.38
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_HRRR_20241204  COMPLETE              34.99
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              39.68
grid_RRFS_CONUScompact_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_  COMPLETE              11.70
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024120  COMPLETE              32.31
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              11.03
grid_RRFS_CONUScompact_25km_ics_RRFS_lbcs_RRFS_suite_RRFS_v1beta_  COMPLETE              14.20
grid_RRFS_CONUScompact_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_2  COMPLETE             394.59
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_HRRR_202412040  COMPLETE             417.01
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_20  COMPLETE             428.75
grid_RRFS_NA_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241204003229  COMPLETE              93.25
grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_WoFS_v0_202412  COMPLETE              31.25
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024120400323  COMPLETE              23.93
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241204003  COMPLETE              18.41
grid_SUBCONUS_Ind_3km_ics_NAM_lbcs_NAM_suite_GFS_v16_202412040032  COMPLETE              24.20
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot_202  COMPLETE              11.92
MET_ensemble_verification_only_vx_20241204003234                   COMPLETE               0.88
MET_ensemble_verification_winter_wx_20241204003236                 COMPLETE             138.80
MET_verification_only_vx_20241204003237                            COMPLETE               0.26
pregen_grid_orog_sfc_climo_20241204003239                          COMPLETE               9.91
specify_EXTRN_MDL_SYSBASEDIR_ICS_LBCS_20241204003241               COMPLETE               8.82
specify_template_filenames_20241204003242                          COMPLETE               9.97
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            7277.08

Detailed summary written to /gpfs/f6/bil-fire8/world-shared/Ratko.Vasic/SRW/expt_dirs/WE2E_summary_20241204031723.txt

For runs used UFS-WM branch: https://github.com/BrianCurtis-NOAA/ufs-weather-model.git -b gaeac6 PR#2448

@MichaelLueken MichaelLueken changed the title Port SRW to Gaea C6 [develop] Port SRW to Gaea C6 Dec 4, 2024
@MichaelLueken
Copy link
Collaborator

@RatkoVasic-NOAA I have discussed the Jenkins labels for Gaea-C5 and Gaea-C6 with Kris Booker. The newly added gaea-c6 label will work in Jenkins, but there are no plans for changing the current gaea label to gaea-c5. We will need to change the gaea-c5 entries back to gaea, otherwise the automated tests will fail.

I'm working in a copy of your branch to remove -c5 from gaea-c5 throughout your gaea-c6 branch. I'll let you know and open a PR into your branch once the automated build and run scripts work on Gaea using gaea rather than gaea-c5.

@RatkoVasic-NOAA
Copy link
Collaborator Author

@MichaelLueken that's OK. I'm currently running tests on: Hera, Hercules, Jet, Orion, Gaea-C5, Gaea-C6, and Derecho. Some are already done. I'll retest gaea-c5 after your changes.

@MichaelLueken
Copy link
Collaborator

@RatkoVasic-NOAA The majority of the modifications have been made and the both the automated build script (srw_build.sh) and the wrapper test script (wrapper_srw_ftest.sh) have been successfully tested on Gaea-C5, following the changes from gaea-c5 back to gaea. The final srw_test.sh script is now running. I should be able to open a PR into your gaea-c6 branch in the morning.

@RatkoVasic-NOAA
Copy link
Collaborator Author

Hera:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              13.62
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               9.53
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              26.56
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024121  COMPLETE              44.96
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241219180  COMPLETE              25.86
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024121918043  COMPLETE              48.59
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             169.12

Jet:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              12.26
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               9.97
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              28.55
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024121  COMPLETE              49.54
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241219210  COMPLETE              31.96
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024121921091  COMPLETE              48.82
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             181.10

Gaea-c6:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              10.32
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               8.07
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              19.36
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024121  COMPLETE              30.18
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241219150  COMPLETE              15.71
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024121915080  COMPLETE              39.11
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             122.75

Orion:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              17.78
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE              12.36
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              41.80
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024121  COMPLETE              48.84
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241219145  COMPLETE              32.64
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024121914553  COMPLETE              79.76
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             233.18

Hercules:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              10.50
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               8.09
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              22.77
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024121  COMPLETE              41.00
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241219120  COMPLETE              27.51
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024121912043  COMPLETE              39.71
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             149.58

Derecho:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              18.77
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE              15.59
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              36.19
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024121  COMPLETE              56.55
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241219135  COMPLETE              27.86
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024121913560  COMPLETE              64.30
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             219.26

@MichaelLueken
Copy link
Collaborator

@RatkoVasic-NOAA PR #15 was created in your fork. Once merged, this PR will be ready for review.

@RatkoVasic-NOAA
Merge pull request #15 from MichaelLueken/gaea-c6
28f5807 
[gaea-c6] Replace gaea-c5 with gaea to allow Jenkins automated testing to pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkavulich mkavulich Awaiting requested review from mkavulich mkavulich will be requested when the pull request is marked ready for review mkavulich is a code owner

@gsketefian gsketefian Awaiting requested review from gsketefian gsketefian will be requested when the pull request is marked ready for review gsketefian is a code owner

@JeffBeck-NOAA JeffBeck-NOAA Awaiting requested review from JeffBeck-NOAA JeffBeck-NOAA will be requested when the pull request is marked ready for review JeffBeck-NOAA is a code owner

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA BenjaminBlake-NOAA will be requested when the pull request is marked ready for review BenjaminBlake-NOAA is a code owner

@ywangwof ywangwof Awaiting requested review from ywangwof ywangwof will be requested when the pull request is marked ready for review ywangwof is a code owner

@chan-hoo chan-hoo Awaiting requested review from chan-hoo chan-hoo will be requested when the pull request is marked ready for review chan-hoo is a code owner

@panll panll Awaiting requested review from panll panll will be requested when the pull request is marked ready for review panll is a code owner

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA will be requested when the pull request is marked ready for review christinaholtNOAA is a code owner

@christopherwharrop-noaa christopherwharrop-noaa Awaiting requested review from christopherwharrop-noaa christopherwharrop-noaa will be requested when the pull request is marked ready for review christopherwharrop-noaa is a code owner

@danielabdi-noaa danielabdi-noaa Awaiting requested review from danielabdi-noaa danielabdi-noaa will be requested when the pull request is marked ready for review danielabdi-noaa is a code owner

@mark-a-potts mark-a-potts Awaiting requested review from mark-a-potts mark-a-potts will be requested when the pull request is marked ready for review mark-a-potts is a code owner

@jkbk2004 jkbk2004 Awaiting requested review from jkbk2004 jkbk2004 will be requested when the pull request is marked ready for review jkbk2004 is a code owner

@willmayfield willmayfield Awaiting requested review from willmayfield willmayfield will be requested when the pull request is marked ready for review willmayfield is a code owner

@dmwright526 dmwright526 Awaiting requested review from dmwright526 dmwright526 will be requested when the pull request is marked ready for review dmwright526 is a code owner

@gspetro-NOAA gspetro-NOAA Awaiting requested review from gspetro-NOAA gspetro-NOAA will be requested when the pull request is marked ready for review gspetro-NOAA is a code owner

@natalie-perlin natalie-perlin Awaiting requested review from natalie-perlin natalie-perlin will be requested when the pull request is marked ready for review natalie-perlin is a code owner

@EdwardSnyder-NOAA EdwardSnyder-NOAA Awaiting requested review from EdwardSnyder-NOAA EdwardSnyder-NOAA will be requested when the pull request is marked ready for review EdwardSnyder-NOAA is a code owner

@MichaelLueken MichaelLueken Awaiting requested review from MichaelLueken MichaelLueken will be requested when the pull request is marked ready for review MichaelLueken is a code owner

@rickgrubin-noaa rickgrubin-noaa Awaiting requested review from rickgrubin-noaa rickgrubin-noaa will be requested when the pull request is marked ready for review rickgrubin-noaa is a code owner

@BruceKropp-Raytheon BruceKropp-Raytheon Awaiting requested review from BruceKropp-Raytheon BruceKropp-Raytheon will be requested when the pull request is marked ready for review BruceKropp-Raytheon is a code owner

@BenKoziol-NOAA BenKoziol-NOAA Awaiting requested review from BenKoziol-NOAA BenKoziol-NOAA will be requested when the pull request is marked ready for review BenKoziol-NOAA is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request Work in Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable SRW on Gaea-C6
2 participants
@RatkoVasic-NOAA @MichaelLueken