Add soil temperature and moisture IAU #222
Conversation
…into feature/lnd_iau * 'feature/lnd_iau' of https://github.com/tsga/ccpp-physics: correct the meta file correctly convert from flashes per five minutes to flashes per minute In physics/Interstitials/UFS_SCM_NEPTUNE/maximum_hourly_diagnostics.F90, scale lightning threat from flashes per 5 minutes to flashes per minute to match units in metadata In physics/Interstitials/UFS_SCM_NEPTUNE/maximum_hourly_diagnostics.meta: change units 'flashes 5 min-1' to 'flashes min-1' and update long name to make clear this is per 5 minutes
* tmp: fix arg_table_noahmpdrv_finalize
|
@tsga Are you finished making changes to this PR? |
@grantfirl yes. And the science reviewers are also OK with the changes. The RTs passed (with the -c switch for lnd_iau because its baseline is not on hera). Thank you. |
* ufs/dev: fix another optional argument in RUC LSM fix some more optional variables fix some optional arugments
|
@tsga Sorry for the late re-review. Please see the comments above. The only thing that I think must be changed is the addition of the I feel comfortable approving once the noahmpdrv.meta has been changed. |
@grantfirl no problem, thank you for the feedback. I will address these soon and progress the PR forward. |
|
@grantfirl I have now added the optional=True as you suggested, removed all commented lines that are not descriptive comments. I have also removed most of the print statements. Left few that I think are essential but they are now very few and most printed only once. |
|
Testing for 2415 has completed, please continue with the merge process, thank you. |
|
@tsga @mkavulich It looks like the last commit just got in under the deadline for final UWM tests, so I'm going to go ahead and merge this. |
Thank you so much @grantfirl and everyone for guiding me through these PR. Cheers. |
Add Incremental Analysis Update (IAU) to soil temperature and moisture in the NoahMP land model of the UWM's CCPP. Addresses issue: /issues/190
Regression tests for ATM only and coupled (S2S) configurations pass in hera.
Additional land-IAU specific test to be added: control_c48_intel_land_iau (based on the "control_c48_intel" test, with the only difference being the land IAU increment files added to the INPUT directory .
The input.nml is modified to add "land_iau_nml" (do_land_iau=.true. if executing with land IAU)