Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: performance page #130

Merged

Conversation

lucaskikkawa
Copy link
Contributor

@lucaskikkawa lucaskikkawa commented Jul 6, 2023

Descrição

Lucas - Criação do componente PerformanceGraph.vue

  • Criação Arquivo

Carlos - Criação do PerformanceCard.vue

  • Criação Arquivo
  • Configuração dos Parametros
  • Cor das bordas automaticas

Daniel

  • Responsividade
  • Dados dos cards
  • Estilização dos cards
  • Cards para página de Dados de matrícula

Tickets relacionados

Como testar esse PR

Terminal de Comando na pasta raiz do projeto.

1º - Utilizar o comando yarn install
2º - Utilizar o comando yarn serve
3º - Copiar o endereço host local, como http://localhost:8080/
4º - Clicar no menu estilo "hamburger"
5º - Clicar no opção "Performance

Adicionou/atualizou testes automatizados?

  • Sim
  • Não, porque: Ainda não chegamos nesta etapa do desenvolvimento
  • [] Preciso de ajuda para escrever testes

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ufabc-next-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 2:55am

@lucaskikkawa lucaskikkawa changed the title Feat/performance page Feat/performance_page - Reescrita Página de Performance #108 Jul 6, 2023
@mateusbrg
Copy link
Member

mateusbrg commented Jul 30, 2023

Estudando um pouco as possibilidades de bibliotecas para gráficos no Vue, encontrei algumas alternativas e decidi testá-las:

O vue-chartjs é a variação oficial do chart-js, uma biblioteca de gráficos super utilizada. Entretanto, achei a documentação confusa e "ampla demais", ou seja, embora tenha uma extensibilidade bem abrangente, não fornece implementações e componentes para uso rápido dentro dos projetos.

Na pesquisa, também avaliei o Vue echarts indicado pelo @lucaskikkawa. Embora tenha uma boa documentação, não possui uma gama de opções de gráficos, nem mesmo um gráfico em área encontrei nas docs, o que infelizmente inviabilizaria a migração da página de performance, que utiliza gráficos desse estilo.

Considerei adicionar o ApexCharts, uma biblioteca completa para uso de diversos gráficos, mas, analisando a página de reviews de professores que está em produção hoje, percebi que o gráfico "pizza" usado para ilustrar os conceitos dos professores é da bilbioteca Highcharts.

Portanto, inclui na migração o highcharts, que provavelmente será usada na página de reviews (sendo migrada em #132 ) e sugiro que seja utilizado nos demais gráficos do projeto a fim de não aumentar o tamanho do bundle com mais uma biblioteca gráfica.

Copy link
Member

@Joabesv Joabesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só remover a maior parte dos comentarios

apps/container/src/views/PerformanceView.vue Outdated Show resolved Hide resolved
apps/container/src/views/PerformanceView.vue Outdated Show resolved Hide resolved
apps/container/src/views/PerformanceView.vue Outdated Show resolved Hide resolved
@FusiDaniel FusiDaniel force-pushed the feat/performance-page branch from 8b13548 to 8e0aa3d Compare October 30, 2023 00:01
@FusiDaniel FusiDaniel changed the title Feat/performance_page - Reescrita Página de Performance #108 feat: microfrontend-performance-page Oct 30, 2023
@FusiDaniel FusiDaniel force-pushed the feat/performance-page branch from 8e0aa3d to e3d1fd3 Compare October 30, 2023 02:28
@FusiDaniel FusiDaniel changed the title feat: microfrontend-performance-page feat: performance page Oct 30, 2023
@FusiDaniel FusiDaniel marked this pull request as ready for review October 30, 2023 16:40
@FusiDaniel FusiDaniel merged commit 507800e into ufabc-next:feat/microfrontend Oct 31, 2023
3 checks passed
RenanLorijola pushed a commit that referenced this pull request Nov 25, 2023
* feat: performance card

* fix: history

* feat: performance view

* feat: performance view

* feat: adding chart.js in performance-page

* feat: include highcharts and example

* feat: type performance requests

* fix: api path in performance service

* feat: highcharts type and some styles

* feat: perfromance card and cr history chart

* feat: best quad card and cr distribution fetch

* feat: histories cp route

* feat(wip): cp history by course

* refactor(wip): chart area component

* feat: cards adicionados a página de matricula

* feat: finalize styling and logic

* fix: imports

* fix: stats orderby label

* refactor: settings tanstack

* refactor: graphs and style

* feat: stats cards

* feat: stats page loading

* ci: tsc

---------

Co-authored-by: Carlos Alencar <[email protected]>
Co-authored-by: Mateus Braga <[email protected]>
Co-authored-by: Mateus Braga <[email protected]>
Co-authored-by: FusiDaniel <[email protected]>
RenanLorijola added a commit that referenced this pull request Nov 26, 2023
* feat: project with vue 3

* chore: add vuetify

* chore: editor config

* chore: prettier

* chore: element plus

* chore: commitlint and husky

* fix: linting

* chore: update packages

* ci: github actions

Co-authored-by: Renan Zago Lorijola <[email protected]>

* fix: change project name

* chore: add dependabot

* ci: github actions with yarn (#102)

* fix: eol

* chore: lint staged, jest and license config (#103)

* docs: contributing.md (#104)

* chore: configure axios instance to call apis (#105)

* feat: basic navbar

* feat: routes

* feat: favicon

* feat: reviews as home

* feat: reviews welcome

* feat: better styling drawer

* feat: table and paper components

* fix: drawer external links style

* feat: login dev

Co-authored-by: Daniel Fusimoto Pires <[email protected]>

* fix: drawer not showing

* docs: pull request template (#123)

* docs: pull request template

* docs: usability session

* feat: microfrontend configure (#124)

* fix: jest config

* feat: react components inside vue

* feat: include react project

* feat: history page migration (#131)

* feat: enrollment table style

* feat: table responsive and all dynamic infos

* feat: microfrontend with turbo (#135)

* chore: config turbo

* chore: zustand auth config

* ci: configure ci with turbo

* fix: pr template name

* fix: lint errors

* feat: use same query client in both MF (#136)

* feat: use same query client in both MF

* fix: remove unused mf config

* fix: remove unused files

* fix: queryprovider not found (#139)

* perf: vue store (#141)

* fix: queryprovider not found

* refactor: centralizing vuezustand stores

* feat: settings page (#140)

* fix: queryprovider not found

* fix: gitattributes eol

* refactor: async user requests

* refactor: duplicate 'user' variable name

* refactor: centralizing auth vuezustand store

* feat: google in oauth type

* feat: alias initials composable

* feat: settings view

* fix: fetch user

* refac: zustand logout

Excelente, muito obrigado pela sugestão

Co-authored-by: Renan Zago Lorijola <[email protected]>

* refac: logout redirect

* feat: loading and error cases

---------

Co-authored-by: FusiDaniel <[email protected]>
Co-authored-by: Renan Zago Lorijola <[email protected]>

* chore: jest config

* fix: dev app config

* chore: msw config

* chore: jest vuetify config

* chore: vitest config

* test: history page

* refactor: remove unused jest packages

* fix: incorrect import after merge

* fix: user mock typo

* ci: remove react jest test

* ci: fix eslint

* feat: add vscode settings to apply eslint

* feat: microfrontend reviews page (#149)

* fix: eslint

* feat: packages

* chore: project configs

* feat: components

* feat: layout

* feat: router

* feat: views

* refactor: better falsy comparison

* refactor: typos, renaming and code structure

* fix: highcharts import type

* refactor: remove default imports

* fix: eslint

* fix: history review test

* feat: microfrontend stats page (#150)

* fix: disable retry only in test

* feat: stats page

* fix: eslint issues

* chore: update dependencies

* chore: build configs (#151)

* fix: build

* chore: avoid ts generated files

* ci: cd homolog (#152)

* ci: CD on homolog env

* fix: add _hom suffix

* fix: cd build (#153)

* feat: donate page (#142)

Co-authored-by: FusiDaniel <[email protected]>

* feat: performance page (#130)

* feat: performance card

* fix: history

* feat: performance view

* feat: performance view

* feat: adding chart.js in performance-page

* feat: include highcharts and example

* feat: type performance requests

* fix: api path in performance service

* feat: highcharts type and some styles

* feat: perfromance card and cr history chart

* feat: best quad card and cr distribution fetch

* feat: histories cp route

* feat(wip): cp history by course

* refactor(wip): chart area component

* feat: cards adicionados a página de matricula

* feat: finalize styling and logic

* fix: imports

* fix: stats orderby label

* refactor: settings tanstack

* refactor: graphs and style

* feat: stats cards

* feat: stats page loading

* ci: tsc

---------

Co-authored-by: Carlos Alencar <[email protected]>
Co-authored-by: Mateus Braga <[email protected]>
Co-authored-by: Mateus Braga <[email protected]>
Co-authored-by: FusiDaniel <[email protected]>

* chore: configure ci and cd for production (#154)

* fix: cd trigger (#155)

* fix: unify workflows to trigger both on push

* fix: use same node version

* feat: missing configs (#161)

* feat: missing routes and build configs

* fix: static links

* feat: hide bar if not logged

* fix: missing routes configs

* feat/recovery-page (#162)

* feat: recovery route

* feat(wip): recovery entry page

* feat(wip): support view

* feat(wip): recovery success

* feat(wip): recovery form validation

* fix: mobile sizes

* fix: target blank in links

* feat: form validation (#164)

* feat: form validation

* feat: not authenticated router guard

* feat: images and icons styles

* fix: allow route if token is on params

* feat: calengrade (#165)

* feat: calengrade with default styles

* fix: alt images

* fix: style standards

* feat: calengrade new style

* feat: reset state when reestart

* fix: lint issues

* fix: router for public pages

* feat: remove hash from url

* feat: inject ElMessage in window

* fix: add css svh fallback

* fix: add correct dependecies to react plugins (#167)

* feat: header dynamic info (#170)

* fix: reviews layout shift (#169)

* feat: realase date in menu (#168)

* feat/signup-page (#163)

* feat(wip): form step one

* fix: app bar with confirmed false

* feat: signup page

* refactor: logo height

* feat: sign out button

* feat: confim sign up page

* feat: sign out button on header

* feat: redirect for not confirmed users

* fix: redirect confirmed user

* refactor: folder structure

* refactor: token validation before request

* refactor: remove auth when confirmed

* refactor: confirmed and auth logic

---------

Co-authored-by: FusiDaniel <[email protected]>

* test: components coverage (#171)

* test: coverage of components and layout

* fix: app bar component show logic

* fix: refactor issues

* test: pages (#176)

* test: settings page

* test: stats page

* test: performance page

* test: donate view

* test: mock calengrade view

* test: confirmation view

* test: recovery page

* test: sign up page

* refactor: remove comments and correct import

* feat: highcharts acessibility module

* fix: signup page as confirmed route

---------

Co-authored-by: FusiDaniel <[email protected]>

* test: reviews page (#177)

* fix: query duplicate requests (#178)

* chore: Vue Query Devtools

* fix: paragraph tag instead of heading

* fix: query key typo

* refactor: search variable handling

* fix: search bar and welcome tests

* fix: set not allowed warning on search

* feat: calengrade separting margins

* fix: favicon

* chore: devtools only on local env

---------

Co-authored-by: FusiDaniel <[email protected]>
Co-authored-by: Daniel Fusimoto Pires <[email protected]>
Co-authored-by: Mateus Braga <[email protected]>
Co-authored-by: Daniel Fusimoto Pires <[email protected]>
Co-authored-by: Lucas Kikkawa <[email protected]>
Co-authored-by: Carlos Alencar <[email protected]>
Co-authored-by: Mateus Braga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants