-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(provider): implement comment tombstones for threads #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nperez0111 lets discuss here! 😄 You had some thoughts about the getThreadComments function being able to fetch deleted comments? |
nperez0111
reviewed
Nov 19, 2024
nperez0111
reviewed
Nov 19, 2024
nperez0111
reviewed
Nov 19, 2024
nperez0111
reviewed
Nov 19, 2024
…o represent ISO strings
bdbch
changed the title
Deletion tombstoning
feature(provider): implement comment tombstones for threads
Nov 19, 2024
nperez0111
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
TiptapCollabProvider
class to support handling deleted comments separated from non-deleted comments in threads. The most important changes include adding a newdeletedComments
field to theTCollabThread
type, modifying methods to manage and retrieve deleted comments, and updating the logic for deleting comments.llaborative editing sessions.
Enhancements to thread and comment management:
TiptapCollabProvider.ts
: Added methods to get, create, update, and delete threads and comments, including support for deleted comments. Added JSDoc comments for better documentation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]New configuration options:
TiptapCollabProvider.ts
: IntroduceddeleteThreadOnFirstCommentDelete
option to automatically delete a thread when its first comment is deleted. AddeddefaultDeleteCommentOptions
for handling comment deletion.Updates to data types:
types.ts
: UpdatedTCollabThread
andTCollabComment
types to includedeletedComments
anddeletedAt
fields, respectively. AddedDeleteCommentOptions
type for comment deletion options. [1] [2]