Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(provider): implement comment tombstones for threads #877

Merged
merged 10 commits into from
Nov 20, 2024

Conversation

bdbch
Copy link
Member

@bdbch bdbch commented Nov 19, 2024

This pull request includes changes to the TiptapCollabProvider class to support handling deleted comments separated from non-deleted comments in threads. The most important changes include adding a new deletedComments field to the TCollabThread type, modifying methods to manage and retrieve deleted comments, and updating the logic for deleting comments.
llaborative editing sessions.

Enhancements to thread and comment management:

New configuration options:

  • TiptapCollabProvider.ts: Introduced deleteThreadOnFirstCommentDelete option to automatically delete a thread when its first comment is deleted. Added defaultDeleteCommentOptions for handling comment deletion.

Updates to data types:

  • types.ts: Updated TCollabThread and TCollabComment types to include deletedComments and deletedAt fields, respectively. Added DeleteCommentOptions type for comment deletion options. [1] [2]

@bdbch bdbch requested a review from janthurau November 19, 2024 10:31
@bdbch bdbch self-assigned this Nov 19, 2024
@bdbch bdbch requested a review from nperez0111 November 19, 2024 10:43
@bdbch
Copy link
Member Author

bdbch commented Nov 19, 2024

@nperez0111 lets discuss here! 😄

You had some thoughts about the getThreadComments function being able to fetch deleted comments?

@bdbch bdbch changed the title Deletion tombstoning feature(provider): implement comment tombstones for threads Nov 19, 2024
@bdbch bdbch marked this pull request as ready for review November 20, 2024 10:42
Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@nperez0111 nperez0111 merged commit 25d3884 into main Nov 20, 2024
3 checks passed
@nperez0111 nperez0111 deleted the deletion-tombstoning branch November 20, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants