Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jitsy domain password (jitsi_password) should only be salt #75

Open
datenbank-projekt opened this issue Feb 10, 2021 · 0 comments
Open

Comments

@datenbank-projekt
Copy link

Hi,

the option to set a password in the jitsy mod configuration is good. Thank you.
I suggest, that this should not be a password, but a salt for passwords only.
Maybe the flow could be like this: If no jitsi_password is set, no password should be set (as default). But if jitsi_password holds a value, this should be used as salt to generate a password.
I suggest the password for a session is
the left five characters of the hash of (jitsi_password + session name)
Of course, it could be more than 5 characters - maybe the length of the salt? - but this procedure would enable individual passwords for all activities. This can be important, when the mod is used in a moodle installation with many jitsy-activities.
With only the standard passwort in jitsi_password it's much easer to join a session that one is not supposed to access.

To accomplish such behavior, these changes would do:
in session.php
change
echo " api.executeCommand('password', '".$CFG->jitsi_password."');";
to
echo " api.executeCommand('password', '". substr(md5($CFG->jitsi_password.urlencode($sessionnorm)),0,5) ."');";
and
echo " api.executeCommand('password', '".$CFG->jitsi_password."');";
to
echo " api.executeCommand('password', '". substr(md5($CFG->jitsi_password.urlencode($sessionnorm)),0,5) ."');";

Olaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant