Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint against tidyverse style guide #1

Open
DocEd opened this issue Sep 18, 2019 · 1 comment
Open

Lint against tidyverse style guide #1

DocEd opened this issue Sep 18, 2019 · 1 comment

Comments

@DocEd
Copy link

DocEd commented Sep 18, 2019

@aasiyahrashan this is great work well done. Some suggestions:
Could I suggest you remove the base R stuff. We agreed a while ago to only teach tidyverse so as to not confuse or overload people.
Also could you run everything through a linter like styler (https://github.com/r-lib/styler) to make sure everything conforms to the tidyverse style guide 👍 (https://style.tidyverse.org/)

@aasiyahrashan
Copy link
Collaborator

Done.

The only base R stuff I noticed was the bit where dplyr was contrasted with base R. I removed that, but do you remember noticing anything else?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants