Don't raise 409 errors from OpenSearch #1119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting this back to a draft - it is very odd that we're seeing this 409 behavior because we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1095
Typically we see a conflict because OpenSearch is still trying to update documents at the time that we issue a query for all outdated documents, so we think there are some outdated documents when in reality, some documents just haven't finished updating yet.
I think it's safe to ignore a 409, but I'd like feedback on doing so. In both places that
delete_by_queryis called, the response is printed directly following, so it will be in the logs even if we do get a 409.