Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error boundaries, fallbacks, loading states #396

Open
laholstege opened this issue Jul 24, 2024 · 1 comment
Open

error boundaries, fallbacks, loading states #396

laholstege opened this issue Jul 24, 2024 · 1 comment
Assignees

Comments

@laholstege
Copy link
Contributor

          even tho above we redirect them if they're not a cluster admin, i still like to handle it when returning what to render to cover our bases. something like 
if(isClusterAdmin === false) {
 return <NotAuthorized />
 }

and same goes with any other potential error states. you have your loading states covered, but what happens if fetching the order fails, what renders? it'll be Loading... forever. i'll add the error handling pattern, but i just wanted to point out it's good practice to think about how errors effect both your event handlers/API calls, and what you render

Originally posted by @laholstege in #321 (comment)

@laholstege
Copy link
Contributor Author

#435 adds error boundaries. still need to cover 404s, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant