Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floorplan for example Sky130 VLSI flow #2032

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

ethanwu10
Copy link
Contributor

@ethanwu10 ethanwu10 commented Sep 3, 2024

Update example floorplan used by Sky130 tutorials for changed SRAM instances.

EDIT: The YAML in example-designs also needs to be updated since it overrides vlsi/example-sky130.yml file when the tutorial= argument is passed to make. I've also found more issues with the layout stemming from margins not being aligned properly to the tracks, so I'll try to get all of these fixes rolled into this PR

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See ci:* for full list of labels:

  • ci:fpga-deploy - Run FPGA-based E2E testing
  • ci:local-fpga-buildbitstream-deploy - Build local FPGA bitstreams for platforms that are released
  • ci:disable - Disable CI

@ethanwu10 ethanwu10 marked this pull request as draft September 4, 2024 00:14
Update floorplan for changed SRAM instances.
@ethanwu10 ethanwu10 force-pushed the fix-sky130-example-floorplan branch from 01d417a to e7ac96e Compare September 7, 2024 05:45
@ethanwu10 ethanwu10 marked this pull request as ready for review September 7, 2024 05:45
@jerryz123 jerryz123 merged commit dcc3519 into main Sep 7, 2024
26 of 27 checks passed
@ethanwu10 ethanwu10 deleted the fix-sky130-example-floorplan branch October 23, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants