You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just like in ImageBlock (found in ubyssey.ca/images/blocks.py), I think the PullQuoteBlock (found in ubyssey.ca/article/blocks.py) should have the style choiceblock that gives the option for the quote to be default, left, or right. Left or Right should add a left or right class to the quote (the template is found in ubyssey.ca/article/templates/article/stream_blocks/quote.html).
For reference you can see the imageblock tempalte in ubyssey.ca/images/templates/images/stream_blocks/image_block.html and the styling for .left and .right in ubyssey.ca/ubyssey/static_src/src/styles/modules/article/_embeds.scss
The text was updated successfully, but these errors were encountered:
If I understand the problem statement correctly then I think the embedMargins method in main.js is not used anywhere in the codebase. I commented the other unused code as well.
If I understand the problem statement correctly then I think the embedMargins method in main.js is not used anywhere in the codebase. I commented the other unused code as well.
I meant to sasy that 'embedMargins' is used but I think there is a better way to do it using css instead of javascript
I think another choiceblock for styling would be nice that adds a class to the element. Right now just include a default but afterwards we can discuss new styles for the quote block
The Verge does this with their quotes
Just like in
ImageBlock
(found inubyssey.ca/images/blocks.py
), I think the PullQuoteBlock (found inubyssey.ca/article/blocks.py
) should have the style choiceblock that gives the option for the quote to be default, left, or right. Left or Right should add aleft
orright
class to the quote (the template is found inubyssey.ca/article/templates/article/stream_blocks/quote.html
).For reference you can see the imageblock tempalte in
ubyssey.ca/images/templates/images/stream_blocks/image_block.html
and the styling for.left
and.right
inubyssey.ca/ubyssey/static_src/src/styles/modules/article/_embeds.scss
The text was updated successfully, but these errors were encountered: