Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give option for quote block to go left and right like image block #1467

Open
SamuelmdLow opened this issue May 29, 2024 · 3 comments
Open

Give option for quote block to go left and right like image block #1467

SamuelmdLow opened this issue May 29, 2024 · 3 comments
Assignees

Comments

@SamuelmdLow
Copy link
Member

SamuelmdLow commented May 29, 2024

The Verge does this with their quotes

Just like in ImageBlock (found in ubyssey.ca/images/blocks.py), I think the PullQuoteBlock (found in ubyssey.ca/article/blocks.py) should have the style choiceblock that gives the option for the quote to be default, left, or right. Left or Right should add a left or right class to the quote (the template is found in ubyssey.ca/article/templates/article/stream_blocks/quote.html).

For reference you can see the imageblock tempalte in ubyssey.ca/images/templates/images/stream_blocks/image_block.html and the styling for .left and .right in ubyssey.ca/ubyssey/static_src/src/styles/modules/article/_embeds.scss

@Nishim12 Nishim12 self-assigned this Jul 2, 2024
@Nishim12
Copy link
Contributor

Nishim12 commented Jul 2, 2024

If I understand the problem statement correctly then I think the embedMargins method in main.js is not used anywhere in the codebase. I commented the other unused code as well.

@SamuelmdLow
Copy link
Member Author

If I understand the problem statement correctly then I think the embedMargins method in main.js is not used anywhere in the codebase. I commented the other unused code as well.

I meant to sasy that 'embedMargins' is used but I think there is a better way to do it using css instead of javascript

@Nishim12 Nishim12 linked a pull request Jul 3, 2024 that will close this issue
@SamuelmdLow SamuelmdLow assigned amandahyyee and unassigned Nishim12 Jul 5, 2024
@SamuelmdLow
Copy link
Member Author

I think another choiceblock for styling would be nice that adds a class to the element. Right now just include a default but afterwards we can discuss new styles for the quote block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants