Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra checks? #9

Open
gerblesh opened this issue Jun 27, 2023 · 3 comments
Open

Extra checks? #9

gerblesh opened this issue Jun 27, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gerblesh
Copy link
Collaborator

gerblesh commented Jun 27, 2023

I dunno if it would be the best idea to add some extra update checks, but here's a list of some ideas

  • Memory check:
    I'm not particularly a big fan of this one, as using memory to measure system load isn't very helpful, because applications can cache tons of memory, some use more, some don't and some are more taxing than others, some other OSes/alternative kernels handle memory differently, etc, you get the idea here
  • CPU thermals check:
    I'm not exactly opposed to this idea, I just don't see how this would make things any better as we already check cpu load
  • GPU load check:
    I'm not opposed to this idea, just need more insight into it
  • Network speed check:
    This varies a lot from place to place, so it would be hard to implement, given that network speed varies quite a bit around the world, would definitely need more insight into this one

Feel free to suggest more in the comments in this issue

@gerblesh gerblesh added the enhancement New feature or request label Jun 27, 2023
@gerblesh
Copy link
Collaborator Author

gerblesh commented Jul 3, 2023

moreover, it would also be good to check if updates were available at all, like give the user the ability to add scripts that check for updates, if any of them return success then we continue, the problem becomes, I don't know how to check for distrobox updates, or flatpak updates. So if distrobox or flatpak have an update, but ostree doesn't, the user could miss out on updates to flatpak or distrobox

@gerblesh gerblesh added the help wanted Extra attention is needed label Jul 3, 2023
@gerblesh
Copy link
Collaborator Author

gerblesh commented Jul 4, 2023

ok there's a new PR open for checking updates using skopeo, only works for rpm-ostree distributions with OCI images though: #19

@EyeCantCU EyeCantCU mentioned this issue Jul 4, 2023
@EyeCantCU
Copy link
Member

EyeCantCU commented Jul 6, 2023

Memory checks: After a bit of discussion, I don't believe this would be beneficial. Too many different memory configurations to account for

CPU thermals check: What's acceptable varies quite a bit CPU to CPU. Some run hotter, some colder. I don't think we should implement this.

GPU load check: This is a great idea. This could be pretty useful but there currently isn't consistent tooling to measure this between different vendors (that I'm aware of at least). This should definitely be implemented if otherwise possible.

Network speed check: This got discussed on Discord as well, but I don't think we should implement this. Some people have really slow connections (one user reportedly only had a megabit available to them the other day). There's so many variations here that this could be too intrusive.

However, I do believe a network connectivity check could be useful here. I already use one in steamos-update that I could bring over here. Even though this already needs internet access, that doesn't necessarily mean GitHub/GHCR is going to be up to serve images.

This can easily be handled with a module that runs:

wget -q --spider https://github.com

From where we can pull the return code. This could be an optional inhibitor as well.

People's images may be somewhere else though, so the URL would have to be configurable too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants