Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to handle multiple encrypted disks with luks-tpm. #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krishbin
Copy link

The current scripts assumes that system only spans
over a single encrypted drive. This patch adds
ability to add tpm key slots to multiple encrypted drives and also remove them.

Thank you for contributing to the Universal Blue project!

Please read the Contributor's Guide before submitting a pull request.
I have tested the scripts on my system.
Screenshot from 2024-06-30 23-10-01

Screenshot from 2024-06-30 23-09-29

@krishbin krishbin changed the title Luks-TPM-Scripts: Add ability to handle multiple encrypted disks. feat: Add ability to handle multiple encrypted disks with luks-tpm. Jun 30, 2024
KyleGospo
KyleGospo previously approved these changes Jul 12, 2024
@krishbin
Copy link
Author

krishbin commented Jul 17, 2024

I have refactored my changes to the latest branch.
There luks script was previously refactored in commit 6ff6bef

KyleGospo
KyleGospo previously approved these changes Jul 17, 2024
The current scripts assume that system only spans
over a single encrypted drive. This patch adds
ability to add tpm key slots to multiple encrypted
drives and also remove them.
@KyleGospo
Copy link
Member

Hate to ask for this but could you resolve the conflicts one more time? I'd love to get this merged asap :)

@bsherman
Copy link
Contributor

bsherman commented Nov 2, 2024

I'm hesitant on this.

We only officially support a single, auto-partitioned disk, per our upstream installer.

Until we have more official support for fancier disk configurations, I don't feel confident in adding more complexity to existing tooling which encourages unsupported disk configurations.

For users who are confident with alternative partitioning and LUKS, that's cool, but they also may not need this script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants